MON-3538: Promote MetricsServer FeatureGate to GA

[slashpai]

Placeholder to promote MetricsServer FeatureGate to GA.

This is also to test if tests are failing when promoted to GA

Enhancement proposal: https://github.com/openshift/enhancements/blob/master/enhancements/monitoring/replace-prometheus-adapter-with-metrics-server.md

Autoscaling/HPA uses resource metrics api and we see techpreview jobs for HPA is passing 100%

HPA/Autoscaling Sippy Test Link

Testing APIService during upgrade: https://issues.redhat.com/browse/MON-3539

cc: @simonpasquier @jan--f @juzhao

[openshift-ci-robot]

@slashpai: This pull request references MON-3538 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Placeholder to promote MetricsServer FeatureGate to GA.

This is also to test if tests are failing when promoted to GA

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @slashpai! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[slashpai]

cc: @simonpasquier @jan--f

This was used to trigger all the tests

[deads2k]

Can you either

1. link to the automated tests results in periodic jobs running on a schedule to ensure regression protection both from the owning component and other components via side-effect (cluster-node-tuning-operator just benefited from such protection when an MCO PR broke them)
2. A direct QE sign off that this feature is ready.

See deeper examples of how to be promoted here: https://github.com/openshift/enhancements/blob/master/dev-guide/featuresets.md#id-like-to-declare-a-feature-accessible-by-default--what-is-the-process

[deads2k]

/test verify

[juzhao]

ci/prow/verify failed for
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/1851/pull-ci-openshift-api-master-verify/1778771838210412544

 F0412 13:26:08.030722  159687 root.go:64] Error running codegen: error: only 0 tests found, need at least 5 for "MetricsServer" on {vsphere-ipi amd64 ha}
error: only 0 tests found, need at least 5 for "MetricsServer" on {aws amd64 hypershift}
error: only 0 tests found, need at least 5 for "MetricsServer" on {aws amd64 ha}
error: only 0 tests found, need at least 5 for "MetricsServer" on {azure amd64 ha}
error: only 0 tests found, need at least 5 for "MetricsServer" on {gcp amd64 ha}
make: *** [Makefile:54: verify-scripts] Error 255 

no tests in this PR. QE is working on test this PR with the cluster-bot cluster

[juzhao]

tested on AWS and hypershift-host cluster, metrics-server is enabled by default, just a small bug https://issues.redhat.com/browse/OCPBUGS-32342 should be fixed after GA, metrics-server works well. I think we can merge this PR.

[openshift-ci-robot]

@slashpai: This pull request references MON-3538 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Placeholder to promote MetricsServer FeatureGate to GA.

This is also to test if tests are failing when promoted to GA

Testing APIService during upgrade: https://issues.redhat.com/browse/MON-3539

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[slashpai]

/retest

[slashpai]

/jira refresh

[openshift-ci-robot]

@slashpai: This pull request references MON-3538 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@slashpai: This pull request references MON-3538 which is a valid jira issue.

In response to this:

Placeholder to promote MetricsServer FeatureGate to GA.

This is also to test if tests are failing when promoted to GA

Testing APIService during upgrade: https://issues.redhat.com/browse/MON-3539

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@slashpai: This pull request references MON-3538 which is a valid jira issue.

In response to this:

Placeholder to promote MetricsServer FeatureGate to GA.

This is also to test if tests are failing when promoted to GA

Enhancement proposal: https://github.com/openshift/enhancements/blob/master/enhancements/monitoring/replace-prometheus-adapter-with-metrics-server.md

Autoscaling/HPA uses resource metrics api and we see techpreview jobs for HPA is passing 100%

HPA/Autoscaling Sippy Test Link

Testing APIService during upgrade: https://issues.redhat.com/browse/MON-3539

cc: @simonpasquier @jan--f @juzhao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[juzhao]

see from https://issues.redhat.com/browse/MON-3539 upgrade test is done, no issue.
/label qe-approved

[openshift-ci-robot]

@slashpai: This pull request references MON-3538 which is a valid jira issue.

In response to this:

Placeholder to promote MetricsServer FeatureGate to GA.

This is also to test if tests are failing when promoted to GA

Enhancement proposal: https://github.com/openshift/enhancements/blob/master/enhancements/monitoring/replace-prometheus-adapter-with-metrics-server.md

Autoscaling/HPA uses resource metrics api and we see techpreview jobs for HPA is passing 100%

HPA/Autoscaling Sippy Test Link

Testing APIService during upgrade: https://issues.redhat.com/browse/MON-3539

cc: @simonpasquier @jan--f @juzhao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[slashpai]

/assign @simonpasquier

[deads2k]

QE has signed off
/override ci/prow/verify

/lgtm
/approve

[openshift-ci]

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify

In response to this:

QE has signed off
/override ci/prow/verify

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[slashpai]

/hold cancel

[openshift-ci]

@slashpai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202404190512.p0.g1f60f4c.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.