Correct fix for Slim #1431, #1434, #1435

[minad]

This is the correct way how to fix the issues #1431, #1434, #1435. Since you want to use a capture helper you have to disable the internal Slim capturing. This is how it is also done in Rails. I don't recommend to monkey patch the Slim::Template how you did in #1435.

Unfortunately your test cases somehow don't cover the capturing very well and the problems described in #1431, #1434, #1435. You should definitely improve that.

[minad]

What I don't get is why you replace the output_buffer in the erb and slim handler, but you don't replace the @_out_buf variable in capture_from_template. So why is this working after all?

[DAddYE]

Looks great to me, can't we improve ours tests?

[namusyaka]

It's my fault. Thanks!

[nesquena]

Thanks @minad!

[minad]

Could you improve your tests for capturing? See what I wrote before about @_out_buf. I think the same applies for the erb handler.