stats: support display invalid key in stats buckets #12064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
type/bug-fix
Codecov Report
@@ Coverage Diff @@
## master #12064 +/- ##
===========================================
Coverage 81.5184% 81.5184%
===========================================
Files 448 448
Lines 96123 96123
===========================================
Hits 78358 78358
Misses 12189 12189
Partials 5576 5576 |
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #12094 |
|
cherry pick to release-2.1 failed |
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Sep 9, 2019
sre-bot
pushed a commit
that referenced
this pull request
Sep 10, 2019
zz-jason
pushed a commit
that referenced
this pull request
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
show stats_bucketssometimes shows errors likeinvalid encoded key flag 252.What is changed and how it works?
Feedback may generate invalid index keys, we need to handle these when trying to display values instead of raise errors.
Check List
Tests
Unit test
Code changes
Has exported function/method change
Side effects
Related changes
Release note