Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jquery 1.9.1 Incompatibility #174

Closed
Devolv opened this issue Feb 16, 2013 · 4 comments
Closed

Jquery 1.9.1 Incompatibility #174

Devolv opened this issue Feb 16, 2013 · 4 comments
Assignees
@pisi
Labels
bug resolved
Milestone
1.2.1

Comments

@Devolv
Copy link

Devolv commented Feb 16, 2013

Running the latest Jquery 1.9.1 results in the following Error:

TypeError: k.browser is undefined

When switching back to legacy Jquery 1.8.3, Reel works again.
@pisi
Copy link
Owner

pisi commented Feb 17, 2013

In other words: time for a patch.

Thanks for the notice!

@ghost ghost assigned pisi Feb 17, 2013
pisi added a commit that referenced this issue Feb 20, 2013
@pisi
Added $.reel.re.ua regexp stack for own user agent sensing #174
754e037
pisi added a commit that referenced this issue Feb 20, 2013
@pisi
Using own regular expression(s) to detect browser #174
52143ca
pisi added a commit that referenced this issue Feb 20, 2013
@pisi
Used user agent matching similar to the one used in jQuery Migrate fo…
6dd6871 
…r testing #174
pisi added a commit that referenced this issue Feb 20, 2013
@pisi
Change log update #174
fe49d5e
@pisi
Copy link
Owner

pisi commented Feb 20, 2013

Code on the [development branch] is jQuery 1.9 compatible (in fact it works well with 2.0 beta too!) and is to be released as Reel 1.2.1 within few days.

@pisi pisi closed this as completed Feb 20, 2013
@pisi
Copy link
Owner

pisi commented Feb 20, 2013

@dtrunk90, thanks very much for sharing your fix, which I noticed just now. Kudos to you, sir! The fix indeed does make the trick. I applied a similar solution and though I realize the check there is to specifically catch IE, I came up with a stack of regular expressions ($.reel.re.ua) to identify the browser on my own. It basically is an optimized version of what's in the jQuery Migrate poly-fill plugin (whose full logic I employed in tests, which support this feature). However, thank you very much for your effort, Danny :)

pisi added a commit that referenced this issue Feb 20, 2013
@pisi
Added $.reel.re.ua regexp stack for own user agent sensing #174
614962c
pisi added a commit that referenced this issue Feb 20, 2013
@pisi
Using own regular expression(s) to detect browser #174
43ed7c9
pisi added a commit that referenced this issue Feb 20, 2013
@pisi
Used user agent matching similar to the one used in jQuery Migrate fo…
23a1f51 
…r testing #174
pisi added a commit that referenced this issue Feb 20, 2013
@pisi
Change log update #174
cb7aac0
pisi added a commit that referenced this issue Feb 23, 2013
@pisi
Reel 1.2.1
ccea432 
========

* new exciting multi-row stitched panorama possibility
* full compatibility with jQuery 1.9.x and 2.0 beta
* one less dependency (disableTextSelect)
* fixed page scrolling on touch devices
* maximal throw velocity via `throwable`
* image assets folder
* fixed image sequence allowing for odd starting points

Includes fixes for issues #129, #140, #174, #175, #142, #146, #144, #129, #172
@pisi
Copy link
Owner

pisi commented Feb 23, 2013

Merged into master and included in today's version 1.2.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pisi pisi

Labels
bug resolved
Projects
None yet
Milestone
1.2.1
Development

No branches or pull requests
2 participants
@pisi @Devolv