Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marker and warning for beatmaps with NSFW content #6575

Merged
merged 26 commits into from Jan 5, 2021

Conversation

cl8n
Copy link
Member

@cl8n cl8n commented Aug 30, 2020

closes #5902

adds:

  • ability to mark maps as NSFW with metadata editor
  • a warning screen before viewing a NSFW map
  • exclusion of NSFW maps from search
  • an account setting to turn off the warning/search stuff

design and language are just my guesses what I thought looked okay, the warning is very similar styling to the report form

@peppy
Copy link
Sponsor Member

peppy commented Aug 31, 2020

Thanks for the contribution!

One think I'll mention initially is that we should probably find a better term than NSFW, unless that's commonly used on other sites aimed at a younger audience?

"Potentially offensive content" or something?

@peppy
Copy link
Sponsor Member

peppy commented Aug 31, 2020

I can't think of a better acronym/term to use internally, so I guess nsfw works fine from that perspective. Open to suggestion, though.

@ribbanya
Copy link

"Explicit (content)" is used on songs and other media when concerning a younger demographic, at least in the US.

@nanaya
Copy link
Collaborator

nanaya commented Aug 31, 2020

is it only for older stuff or we're still allowing new nsfw stuff?

@peppy
Copy link
Sponsor Member

peppy commented Aug 31, 2020

There are still new edge cases which this would apply to.

@cl8n
Copy link
Member Author

cl8n commented Aug 31, 2020

should only mods be allowed to change the map nsfw setting? right now it's the same as genre/language permission, so the mapper and BNs can change it too before it's ranked

updated wording in 5668130

@Ephemeralis
Copy link
Member

NSFW is the 2020 gold standard given its prevalence on platforms like Reddit. Probably no need to change it.

Other alternatives could be 18+, Mature (M), Explicit. Localizing this could be a good way to target specific regulation terms that are prominent in a given language (or culture associated with that language) to allow us to make this as flexible as it needs to be.

nanaya
nanaya previously requested changes Sep 7, 2020
Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • audio preview should be disabled for nsfw maps' card
  • add explicit badge to the beatmap card. Color orange-2, font size 10px, padding 0.2em 1em, background b5, border radius 10k px, margin left 10px, align center with title with +2px from top adjustment. Title itself should have ellipsis on overflow but the badge should always be shown
  • also for beatmap page itself

resources/assets/less/bem/nsfw-warning.less Outdated Show resolved Hide resolved
resources/assets/less/bem/nsfw-warning.less Outdated Show resolved Hide resolved
resources/assets/less/bem/nsfw-warning.less Outdated Show resolved Hide resolved
resources/assets/lib/beatmapsets-show/metadata-editor.tsx Outdated Show resolved Hide resolved
resources/assets/lib/beatmapsets-show/nsfw-warning.tsx Outdated Show resolved Hide resolved
@peppy
Copy link
Sponsor Member

peppy commented Nov 3, 2020

@cl8n i think this is pending on applying a review from your end!

@Ephemeralis
Copy link
Member

@cl8n @peppy @nanaya @notbakaneko can one or more of you take this over to get something out ASAP in order to stop things from boiling over?

@nanaya nanaya dismissed their stale review December 18, 2020 12:10

updated by myself

Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if the index and schema update should be split out so they can be run first? Otherwise, users will get a page of nothing on the listing until the index is updated.

Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how useful hiding the result from the beatmap listing is when there's no option to change the setting there (and the cover is masked/blocked already).

There's also the issue of notifications since those just use the url embedded into the notification itself.

app/Transformers/BeatmapsetTransformer.php Outdated Show resolved Hide resolved
@nanaya
Copy link
Collaborator

nanaya commented Dec 21, 2020

The notification part is probably a lost cause ( ゚ ヮ゚)

The closest thing I can think of is removing the cover altogether based on its nsfw state at the time of notification regardless of the users' nsfw settings.

@peppy
Copy link
Sponsor Member

peppy commented Dec 21, 2020

Let's just ignore notifications until someone complains about it.

@nanaya
Copy link
Collaborator

nanaya commented Dec 21, 2020

Added option for the search filter. Currently boolean (false to exclude, true to include, null to follow user settings). Pondered about adding it as part of Extra or General section but they don't support a third state, only true and default.

@peppy
Copy link
Sponsor Member

peppy commented Dec 28, 2020

Indexing has been run now, merge at your discretion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label 18+ content with a “explicit” mark
6 participants