New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marker and warning for beatmaps with NSFW content #6575
Conversation
Thanks for the contribution! One think I'll mention initially is that we should probably find a better term than NSFW, unless that's commonly used on other sites aimed at a younger audience? "Potentially offensive content" or something? |
I can't think of a better acronym/term to use internally, so I guess nsfw works fine from that perspective. Open to suggestion, though. |
"Explicit (content)" is used on songs and other media when concerning a younger demographic, at least in the US. |
is it only for older stuff or we're still allowing new nsfw stuff? |
There are still new edge cases which this would apply to. |
should only mods be allowed to change the map nsfw setting? right now it's the same as genre/language permission, so the mapper and BNs can change it too before it's ranked updated wording in 5668130 |
NSFW is the 2020 gold standard given its prevalence on platforms like Reddit. Probably no need to change it. Other alternatives could be 18+, Mature (M), Explicit. Localizing this could be a good way to target specific regulation terms that are prominent in a given language (or culture associated with that language) to allow us to make this as flexible as it needs to be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- audio preview should be disabled for nsfw maps' card
- add explicit badge to the beatmap card. Color
orange-2
, font size 10px, padding0.2em 1em
, backgroundb5
, border radius 10k px, margin left 10px, align center with title with +2px from top adjustment. Title itself should have ellipsis on overflow but the badge should always be shown
- also for beatmap page itself
@cl8n i think this is pending on applying a review from your end! |
@cl8n @peppy @nanaya @notbakaneko can one or more of you take this over to get something out ASAP in order to stop things from boiling over? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if the index and schema update should be split out so they can be run first? Otherwise, users will get a page of nothing on the listing until the index is updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how useful hiding the result from the beatmap listing is when there's no option to change the setting there (and the cover is masked/blocked already).
There's also the issue of notifications since those just use the url embedded into the notification itself.
The notification part is probably a lost cause ( ゚ ヮ゚) The closest thing I can think of is removing the cover altogether based on its nsfw state at the time of notification regardless of the users' nsfw settings. |
Let's just ignore notifications until someone complains about it. |
Indexing has been run now, merge at your discretion. |
closes #5902
adds:
design and language are just my guesses what I thought looked okay, the warning is very similar styling to the report form
php artisan es:index-documents --types=beatmapsets --yes