fix(capi): Compatibility with GEOS 3.12 #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuonOmo
force-pushed
the
fix/capi-no-z
branch
2 times, most recently
from
f6b682d
to
3537e29
Compare
keithdoggett
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
LGTM thanks for the quick fixes on this @BuonOmo. It's nice that we're able to keep all the versioning logic in the tests for this.
Related to this I should have some time to keep looking at the Geos gh test matrix soon as well.
test/geos_capi/polygon_test.rb
Outdated
| @@ -90,7 +90,12 @@ def test_simplify_preserve_topology | |||
| simplified = poly.simplify_preserve_topology(1) | |||
| interior_points = simplified.interior_rings[0].points | |||
|
|
|||
| assert_equal 5, interior_points.length | |||
| # https://github.com/libgeos/geos/pull/784 | |||
| if Gem::Version.new(RGeo::Geos.version) >= Gem::Version.new("3.12.0") | |||
There was a problem hiding this comment.
Maybe we add this check as a method in test_helper.rb in case we need to do this check in the future.
def geos_version_gteq(version)
Gem::Version.new(RGeo::Geos.version) >= Gem::Version.new(version)
end
The 3.12 include changes in the API responses. Mainly, WBX Writers now default to three dimensions instead of two. We follow the changes, making no breaking change in the API, but some changes in the responses given by `#ccw?` and `#simplify_preserve_topology`. See changes in libgeos: - libgeos/geos#784 - libgeos/geos#878 - libgeos/geos#908 - libgeos/geos#915 Fixes #360
|
I've applied the change, may I leave you the duty of merging if it suits you ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3.12 include changes in the API responses.
Mainly, WBX Writers now default to three
dimensions instead of two. We follow the
changes, making no breaking change in the
API, but some changes in the responses
given by
#ccw?and#simplify_preserve_topology.See changes in libgeos:
Fixes #360