New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added funding as reverse of fundedItem #2618
Conversation
@stain this PR is failing integration tests. In your development environment does the |
Thanks @RichardWallis, I was puzzled by the Admittedly it is quite hard to get the gcloud development environment to work in the first place..even when using the https://hub.docker.com/r/google/cloud-sdk/ docker image:
I had forgot to do inverse both direction - see ff0819d (still a question for #383 folks if the |
re the inverse question, I'd argue that if any Thing can be a fundedItem, for logical consistency, any Thing might have funding. |
In principle, I would agree with you. In practice, however, such a move would have significant impacts that should be seriously considered before proceeding. Adding Thing to the domainIncludes of a property will effectively add that property to 829 Types. For a large proportion of these types (Volcano, Review, Invoice, etc.) a There needs to be a really strong use case, and examples of who would consume such data, to add properties to the Thing type. |
I see what you're saying, makes good practical sense. Logically the problem is in the definition of fundedItem. As you point out since the range of funded item is Thing, a grant can fund a Landform, Invoice etc. If the domain of funding is not the range of fundedItem then they shouldn't be defined as inverse properties. Options: 1. change the range of fundedItem, or 2. don't define funding and fundedItem as inverse properties. What kinds of Thing can have funding... |
@smrgeoinfo in an OWL world we would make Alternatively make However in schema.org we are softer - e.g. even https://schema.org/domainIncludes itself is not exclusive - it just lists some of the classes that are valid domains (and hence later additions is not a problem). I can use a schema.org property like http://schema.org/creator on my own custom type http://example.com/Universe that does not fit into the schema.org hierarchy, and nothing weird is inferred or broken. I don't know if the schema.org is consistent in opposite domain/range across the existing inverses. Thus my reasoning, that even if any I would not object to If anything we can tighten a bit |
@smrgeoinfo would it make sense that
Can add something like this to
(Not sure about the recursion to |
I suppose a grant can be funded by multiple other grants. if its 1:1 that would be odd. On that basis, I think suggesting domain of funding to be {CreativeWork, Event, MonetaryGrant, Organization, Person} would be a reasonable solution. |
AFAICT funding always relates to an activity. |
Yes, @dr-shorthair there is an activity behind creating anything. The actual provenance then would detail how different work and people contributed to what aspects. We explore some of that in https://researchobject.github.io/ro-crate/1.0/#provenance-equipment-used-to-create-files - even there you will find use for a Many funders require/encourage you to attribute their funding codes etc in their "research outputs" - and so this is basically this direct property, without having to expand on a detailed provenance chain. It is also filling the missing hole as the existing I'll modify this PR to reflect the types agreed with @smrgeoinfo - if you agree we can also change the range of |
Make the list more specific, while also permitting other types, as agreed in schemaorg#2618 (comment)
@RichardWallis how should I suggest an addition to the |
See also discussion in issue #2258 |
OK, I added further crosslink between As you see I also added links to the specific types |
Sorry @RichardWallis although extending the
So I don't know how to do this cross-link, as the |
In 4ba1d8d to avoid that |
See schemaorg#383 (comment) To avoid adding to Thing I made the domainIncludes more specific to CreativeWork, Organization or Person. Perhaps rangeIncludes in fundedItems should be updated accordingly.
Make the list more specific, while also permitting other types, as agreed in schemaorg#2618 (comment)
..Avoid Comment count property errors as ext/pending/issue-383.ttl attempted to override funding
I rebased with master so the tests would pass (needing #2637) It seems agreement has been reached, any chance of merging..? |
Ping to check what else is needed for this PR? |
Hi Richard, happy to contribute some examples from the sciences. If this is useful, I can help put together a pull request. Below you'll find 3 examples:
each with links to web pages from our data repository. GoalIn full appreciation of the complexity of this issue, maybe a simple, small change could help us move forward with a new property to say that some Main reason for this property is to let repositories of Things point to the Grant that funded it. Example screenshot from Zenodo
Understanding that in JSON-LD schema.org publishers can define a ContextProposed Change to schema.orgwith an inverse property to the existing https://schema.org/fundedItem called
EXAMPLESExample 1: Dataset -> GrantURL: https://www.bco-dmo.org/dataset/3300
Example 2: ResearchProject -> GrantURL: https://www.bco-dmo.org/project/2039
Example 3: Organization -> GrantURL: https://www.bco-dmo.org
|
Just trying to keep process moving here. @stain, does #2618 (comment) address your need as well? |
Hi everyone. I'm working on implementing Schema.org metadata for the HydroShare (http://www.hydroshare.org) data repository. The "funding" property described in this pull request would be really useful for us and would meet our use cases well for representing funding agency information provided by data submitters. The comment submitted above by @ashepherd describes HydroShare's use cases nicely. |
I think we're long overdue for a community call on this (zoom, Matrix, Hangouts, whatever...). Who would be available for this, sometime early-mid April? |
Thanks @danbri....I'd be happy to participate and provide use cases on consuming and publishing. @smrgeoinfo @datadavev @mbjones |
I'm happy to participate as well. @ashepherd Would either the April 5th (2pm pacific time) or April 22 (11:30am pacific time) science on schema.org calls be an appropriate venue for such a discussion? |
@danbri, our Science-on-schema.org group from ESIP meets April 5th at 2pmPT but not sure if that's too late? In case that works, here's the Zoom info Telecons via Zoom |
We use schema.org metadata for our paleomagnetic data repository MagIC (earthref.org/MagIC) and having a funding/funder type property in schema.org is important to us. Adding "funded" or "fundedBy" would be great. |
We also need to support such a property for capturing funding details of an (executable) |
@nokome and @njarboe Over at https://science-on-schema.org we've been discussing this and have a proposed approach using
We plan to adopt this approach and promote it across the science community until schema.org adds the needed inverse property. Feedback on our proposed approach fantastic. Here's the example JSON-LD snippet from our guidance docs if people just want to see our representation: {
"@context": "http://schema.org/",
"@type": "Dataset",
"@id": "https://doi.org/10.18739/A22V2CB44",
"name": "Stable water isotope data from Arctic Alaska snow pits in 2019",
"@reverse": {
"fundedItem": [
{
"@type": "MonetaryGrant",
"@id": "https://www.nsf.gov/awardsearch/showAward?AWD_ID=1604105",
"identifier": "1604105",
"name": "Collaborative Research: Nutritional Landscapes of Arctic Caribou: Observations, Experiments, and Models Provide Process-Level Understanding of Forage Traits and Trajectories",
"url": "https://www.nsf.gov/awardsearch/showAward?AWD_ID=1604105",
"funder": {
"@id": "http://dx.doi.org/10.13039/100000001",
"@type": "Organization",
"name": "National Science Foundation",
"identifier": [
"http://dx.doi.org/10.13039/100000001",
"https://ror.org/021nxhr62"
]
}
},
{
"@type": "MonetaryGrant",
"@id": "https://akareport.aka.fi/ibi_apps/WFServlet?IBIF_ex=x_hakkuvaus2&HAKNRO1=316349&UILANG=en&TULOSTE=HTML",
"identifier": "316349",
"name": "Where does water go when snow melts? New spatio-temporal resolution in stable water isotopes measurements to inform cold climate hydrological modelling",
"url": "https://akareport.aka.fi/ibi_apps/WFServlet?IBIF_ex=x_hakkuvaus2&HAKNRO1=316349&UILANG=en&TULOSTE=HTML",
"funder": {
"@id": "http://dx.doi.org/10.13039/501100002341",
"@type": "Organization",
"name": "Academy of Finland",
"identifier": [
"http://dx.doi.org/10.13039/501100002341",
"https://ror.org/05k73zm37"
]
}
}
]
}
} |
Thanks @mbjones, that approach sounds really sensible to me. In Stencila's schema, we'll keep the |
Note that the above is functionally identical to the following. Consumers should handle appropriately: {
"@context": "http://schema.org/",
"@graph": [
{
"@type": "Dataset",
"@id": "https://doi.org/10.18739/A22V2CB44",
"name": "Stable water isotope data from Arctic Alaska snow pits in 2019"
},
{
"@type": "MonetaryGrant",
"@id": "https://www.nsf.gov/awardsearch/showAward?AWD_ID=1604105",
"fundedItem": "https://doi.org/10.18739/A22V2CB44",
"identifier": "1604105",
"name": "Collaborative Research: Nutritional Landscapes of Arctic Caribou: Observations, Experiments, and Models Provide Process-Level Understanding of Forage Traits and Trajectories",
"url": "https://www.nsf.gov/awardsearch/showAward?AWD_ID=1604105",
"funder": {
"@id": "http://dx.doi.org/10.13039/100000001",
"@type": "Organization",
"name": "National Science Foundation",
"identifier": [
"http://dx.doi.org/10.13039/100000001",
"https://ror.org/021nxhr62"
]
}
},
{
"@type": "MonetaryGrant",
"@id": "https://akareport.aka.fi/ibi_apps/WFServlet?IBIF_ex=x_hakkuvaus2&HAKNRO1=316349&UILANG=en&TULOSTE=HTML",
"fundedItem": "https://doi.org/10.18739/A22V2CB44",
"identifier": "316349",
"name": "Where does water go when snow melts? New spatio-temporal resolution in stable water isotopes measurements to inform cold climate hydrological modelling",
"url": "https://akareport.aka.fi/ibi_apps/WFServlet?IBIF_ex=x_hakkuvaus2&HAKNRO1=316349&UILANG=en&TULOSTE=HTML",
"funder": {
"@id": "http://dx.doi.org/10.13039/501100002341",
"@type": "Organization",
"name": "Academy of Finland",
"identifier": [
"http://dx.doi.org/10.13039/501100002341",
"https://ror.org/05k73zm37"
]
}
}
]
} |
@datadavev Yeah, it's logically identical except that the |
The node identifiers can provide such disambiguation. Providing, of course, the values correspond with representations of the respective nodes.
|
So I see the use of |
Can we bypass all the complicated questions on domain/range in #383 thread, and agree that we can't let https://schema.org/Grant stay as-is with documentation of a non-existing To me there seems to be consensus that |
Any objections ?
…On Thu, 20 Jan 2022 at 13:09, Stian Soiland-Reyes ***@***.***> wrote:
Can we bypass all the complicated questions on domain/range in #383
<#383> thread, and agree
that we can't let https://schema.org/Grant stay as-is with documentation
of a non-existing funding property?
To me there seems to be consensus that funding is needed from
CreativeWork, Projects and beyond to avoid climbing down through the
inverse fundedItem?
—
Reply to this email directly, view it on GitHub
<#2618 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJSGMWPFZAET3U4NDPSKTUXACQTANCNFSM4OLLL4GQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
not by me! |
That would be welcome as a change. |
I'm in favour. Thanks to @stain for putting this PR together and persisting with it! |
None! it would be a welcome addition |
I have in effect merged this manually, so I'll close the PR. Thanks, everyone! |
Thanks @danbri that's fantastic. |
See #383 discussion #383 (comment)
To avoid adding to Thing I made the domainIncludes more specific to
CreativeWork, Organization or Person.
Perhaps rangeIncludes in fundedItems should be updated accordingly.