New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make #[dom_struct] a proc_macro attribute #15715
Conversation
Heads up! This PR modifies the following files:
|
@jdm Something tells me you are not going to like this... |
b6be5ea
to
4760004
Compare
☔ The latest upstream changes (presumably #15700) made this pull request unmergeable. Please resolve the merge conflicts. |
Oh yes of course, this is going to get bitrot all the time. |
What's the error message if the import is missing? |
Can we use an absolute path like Or extern crate dom_struct as dom_struct_crate;
pub use dom_struct_crate::dom_struct; |
What's the error message if the import is missing?
That `dom_struct` is undefined, and it suggests to import it with its path printed.
|
Can we use an absolute path like `#[::dom_struct::dom_struct]`, so that no import is needed?
I guess yes but I would rather just keep the import.
|
@bors-servo r+ |
📌 Commit 31e9d81 has been approved by |
Make #[dom_struct] a proc_macro attribute The rustup is needed for rust-lang/rust#40039. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15715) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
The rustup is needed for rust-lang/rust#40039.
This change is