Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of "center left" in parse_origin (fixes #15750) #16435

Merged
merged 1 commit into from Apr 14, 2017
Merged

Fix parsing of "center left" in parse_origin (fixes #15750) #16435

merged 1 commit into from Apr 14, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Apr 13, 2017 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/effects.mako.rs
  • @emilio: components/style/properties/longhand/effects.mako.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 13, 2017
@nox nox changed the title Fix parsing or "center left" in parse_origin (fixes #15750) Fix parsing of "center left" in parse_origin (fixes #15750) Apr 13, 2017
emilio
emilio reviewed Apr 14, 2017
View reviewed changes
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, feel free to stop the build and fixup those if you want.

Thanks a bunch! :)

tests/unit/style/parsing/effects.rs
let mut parser = Parser::new("1% right");
let parsed = longhands::parse_origin(&context, &mut parser);
assert!(parsed.is_ok());
assert_eq!(parser.is_exhausted(), false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just assert!(!parser.is_exhausted()) (same for the others)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though I guess it's pre-existing, hmm..)

@emilio
Copy link
Member

emilio commented Apr 14, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit ff2cf2c has been approved by emilio

@highfive highfive assigned emilio and unassigned cbrewster Apr 14, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 14, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit ff2cf2c with merge f7896fd...

bors-servo pushed a commit that referenced this pull request Apr 14, 2017
Auto merge of #16435 - nox:parse-origin, r=emilio
f7896fd 
Fix parsing of "center left" in parse_origin (fixes #15750)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16435)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing f7896fd to master...

@bors-servo bors-servo merged commit ff2cf2c into servo:master Apr 14, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 14, 2017
@bors-servo bors-servo mentioned this pull request Apr 14, 2017
Merged
2 tasks
@nox nox deleted the parse-origin branch April 18, 2017 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio left review comments

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nox @highfive @emilio @bors-servo @cbrewster