-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of "center left" in parse_origin (fixes #15750) #16435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, feel free to stop the build and fixup those if you want.
Thanks a bunch! :)
let mut parser = Parser::new("1% right"); | ||
let parsed = longhands::parse_origin(&context, &mut parser); | ||
assert!(parsed.is_ok()); | ||
assert_eq!(parser.is_exhausted(), false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just assert!(!parser.is_exhausted())
(same for the others)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(though I guess it's pre-existing, hmm..)
@bors-servo r+ |
📌 Commit ff2cf2c has been approved by |
Fix parsing of "center left" in parse_origin (fixes #15750) <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16435) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
This change is