New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed BrowsingContext to WindowProxy in script. #16845
Renamed BrowsingContext to WindowProxy in script. #16845
Conversation
Heads up! This PR modifies the following files:
|
cc @jdm @cbrewster |
@@ -34,8 +34,7 @@ DOMInterfaces = { | |||
}, | |||
|
|||
'WindowProxy' : { | |||
'nativeType': 'BrowsingContext', | |||
'path': 'dom::browsingcontext::BrowsingContext', | |||
'path': 'dom::windowproxy::WindowProxy', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably isn't needed any more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried removing it and got:
error[E0432]: unresolved import `dom::types::WindowProxy`
--> /home/ajeffrey/github/asajeffrey/servo/target/debug/build/script-dcc60cde0df0c3a0/out/Bindings/DissimilarOriginWindowBinding.rs:339:5
|
339 | use dom::types::WindowProxy;
| ^^^^^^^^^^^^^^^^^^^^^^^ no `WindowProxy` in `dom::types`
error[E0432]: unresolved import `dom::types::WindowProxy`
--> /home/ajeffrey/github/asajeffrey/servo/target/debug/build/script-dcc60cde0df0c3a0/out/Bindings/HTMLIFrameElementBinding.rs:342:5
|
342 | use dom::types::WindowProxy;
| ^^^^^^^^^^^^^^^^^^^^^^^ no `WindowProxy` in `dom::types`
error[E0432]: unresolved import `dom::types::WindowProxy`
--> /home/ajeffrey/github/asajeffrey/servo/target/debug/build/script-dcc60cde0df0c3a0/out/Bindings/WindowBinding.rs:647:5
|
647 | use dom::types::WindowProxy;
| ^^^^^^^^^^^^^^^^^^^^^^^ no `WindowProxy` in `dom::types`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok!
Otherwise this looks good to me. |
@bors-servo: r+ |
📌 Commit 43ca260 has been approved by |
Renamed BrowsingContext to WindowProxy in script. <!-- Please describe your changes on the following line: --> Renamed `script::dom::BrowsingContext` to `script::dom::WindowProxy`. The browsing context is mostly maintained in the constellation, not in script. It would be nice to rename `constellation::Frame` to `constellation::BrowsingContext`, but that will be very confusing if there are two `BrowsingContext` types. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because renamings aren't externally visible <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16845) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
Renamed
script::dom::BrowsingContext
toscript::dom::WindowProxy
.The browsing context is mostly maintained in the constellation, not in script. It would be nice to rename
constellation::Frame
toconstellation::BrowsingContext
, but that will be very confusing if there are twoBrowsingContext
types../mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is