Added exception-handling to worker wpt tests. #17475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highfive
added
the
S-awaiting-review
|
r? @emilio |
|
cc @jgraham |
|
Looks reasonable to me, but I'd like @jdm to look at it and stamp it. Thanks! |
jdm
reviewed
Jun 22, 2017
| @@ -4,6 +4,10 @@ | |||
| <script src=/resources/testharness.js></script> | |||
| <script src=/resources/testharnessreport.js></script> | |||
| <script> | |||
| // The worker events races with the window's load event; if the worker events | |||
| // arrive first, the harness will detect the error event and fail the test. | |||
| setup({ allow_uncaught_exception: true }); | |||
There was a problem hiding this comment.
Why this instead of calling preventDefault?
There was a problem hiding this comment.
Because it's what all the other tests do:
$ grep -ir allow_uncaught_exception tests/wpt/web-platform-tests/workers/
tests/wpt/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_filename.htm:setup({ allow_uncaught_exception: true });
tests/wpt/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_lineno.htm:setup({ allow_uncaught_exception: true });
tests/wpt/web-platform-tests/workers/Worker_ErrorEvent_type.htm:setup({ allow_uncaught_exception: true });
tests/wpt/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/propagate-to-window-onerror.html: allow_uncaught_exception: true,
tests/wpt/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm:setup({ allow_uncaught_exception: true });
tests/wpt/web-platform-tests/workers/constructors/SharedWorker/same-origin.html:setup({allow_uncaught_exception: true});
tests/wpt/web-platform-tests/workers/constructors/Worker/AbstractWorker.onerror.html:setup({allow_uncaught_exception:true});
tests/wpt/web-platform-tests/workers/constructors/Worker/same-origin.html:setup({allow_uncaught_exception: true});
tests/wpt/web-platform-tests/workers/Worker_ErrorEvent_message.htm:setup({ allow_uncaught_exception: true });
tests/wpt/web-platform-tests/workers/Worker_ErrorEvent_bubbles_cancelable.htm:setup({ allow_uncaught_exception: true });
tests/wpt/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_message.htm:setup({ allow_uncaught_exception: true });
tests/wpt/web-platform-tests/workers/Worker_ErrorEvent_filename.htm:setup({ allow_uncaught_exception: true });
tests/wpt/web-platform-tests/workers/Worker_ErrorEvent_lineno.htm:setup({ allow_uncaught_exception: true });
tests/wpt/web-platform-tests/workers/semantics/reporting-errors/004.html:setup({allow_uncaught_exception:true});
tests/wpt/web-platform-tests/workers/semantics/reporting-errors/002.html:setup({allow_uncaught_exception:true});
tests/wpt/web-platform-tests/workers/semantics/reporting-errors/001.html:setup({allow_uncaught_exception:true});
tests/wpt/web-platform-tests/workers/semantics/reporting-errors/003.html:setup({allow_uncaught_exception:true});
tests/wpt/web-platform-tests/workers/semantics/run-a-worker/003.html:setup({allow_uncaught_exception: true});
The odd one out is data-url.html, since some of the tests should raise an exception and some should not, so in that case I explicitly blocked the exception from propagating.
|
@bors-servo: r+ |
|
📌 Commit 030e01c has been approved by |
highfive
added
S-awaiting-merge
|
⌛ Testing commit 030e01c with merge 14e9bca0a7a94db80c98bc8bfc9bd5817d40a924... |
|
⛄ The build was interrupted to prioritize another pull request. |
bors-servo
pushed a commit
that referenced
this pull request
Jun 23, 2017
Added exception-handling to worker wpt tests. <!-- Please describe your changes on the following line: --> Added exception-handling to worker wpt tests. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15668 and #17460 - [X] These changes do not require tests because these are tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17475) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
jdm
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 6, 2017
Upstreamed from servo/servo#17475 [ci skip]
This was referenced Oct 6, 2017
jdm
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 12, 2017
Upstreamed from servo/servo#17475 [ci skip]
jakearchibald
pushed a commit
to jakearchibald/web-platform-tests
that referenced
this pull request
Nov 16, 2017
Upstreamed from servo/servo#17475 [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added exception-handling to worker wpt tests.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is