Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace default configuration file location #169

Open
dvzrv opened this issue Feb 24, 2021 · 0 comments · May be fixed by #170
Open

Namespace default configuration file location #169

dvzrv opened this issue Feb 24, 2021 · 0 comments · May be fixed by #170

Comments

@dvzrv
Copy link
Contributor

dvzrv commented Feb 24, 2021

In #164 I changed the default configuration file location to be namespaced. Upon request by @fatbob313 this has been amended in #165 to be without namespace again.

As mentioned in #165 (comment) (after the fact) I believe the default configuration file location should actually be namespaced, given, that umurmur relies on a keypair, that needs to be stored in a location, that it has access to (but ideally no other application). In the default configuration file, this is taking place in a namespaced location below /etc/. This is the reason, why I believe the default location of the configuration file should be below that directory as well, as it makes no sense to clutter /etc/ with more files, if a directory is already in use.

dvzrv added a commit to dvzrv/umurmur that referenced this issue Feb 24, 2021
src/config.h.in:
Namespace the default configuration file location with the project's
name "umurmur", as in that location also the required certificates are
expected by default and using a namespaced location makes sense as to
not clutter the SYSCONFDIR (e.g. /etc/) with more files, as a namespace
is necessary anyways.

CMakeLists.txt:
Install the default configuration file to a "umurmur" namespaced
location.

Fixes umurmur#169
@dvzrv dvzrv linked a pull request Feb 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant