Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install config to /etc/umurmur.conf #165

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

dvzrv
Copy link
Contributor

@dvzrv dvzrv commented Jan 14, 2021

CMakeLists.txt:
The changes introduced in #164 install the configuration to
/etc/umurmur/umurmur.conf by default. However, umurmurd is picking up
the configuration from /etc/umurmur.conf automatically, which makes that
location a more logical default.

CMakeLists.txt:
The changes introduced in umurmur#164 install the configuration to
/etc/umurmur/umurmur.conf by default. However, umurmurd is picking up
the configuration from /etc/umurmur.conf automatically, which makes that
location a more logical default.
@anthraxx
Copy link

Or, depending what upstream wishes, the location in the code can be extended to also support /etc/umurmur/umurmur.conf. I think directory namespaces in /etc are not a bad idea overall, they are naturally namespacing a group of configs if ever more files would be added.

@fatbob313 fatbob313 merged commit 8045f96 into umurmur:master Jan 17, 2021
@fatbob313
Copy link
Member

I ran into some problems with config file location which was solved by using CMAKE_INSTALL_FULL_SYSCONFDIR instead. Changed this in 5020ee6
I agree that it's not a bad idea to look in subdir 'umurmur'. PR is welcome.

@dvzrv
Copy link
Contributor Author

dvzrv commented Feb 11, 2021

@fatbob313 I just realized that installing the config to /etc/umurmur/ makes much more sense, as the default configuration also assumes the generated keys in that directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants