Install config to CMAKE_INSTALL_SYSCONFDIR #164
Conversation
CMakeLists.txt: Include GNUInstallDirs and use CMAKE_INSTALL_SYSCONFDIR to install the example configuration (defaults to /etc/umurmur/umurmur.conf). The configuration is installed with 0640 permissions as it may contain passwords and therefore should not be world readable. Remove prior checks to the system for umurmur.conf as the merging or backup of configuration files is historically taken care of by a package management system on a target system.
|
Merged. Thanks! |
|
So, I was a bit too quick there... Any particular reason that the config is installed in the 'umurmur' subdir? As it is, umurmurd looks for it in /etc/ by default. |
|
@fatbob313 Not really besides "we use it like this on Arch Linux". Sorry, I was not aware of the fact, that umurmur picks up a config by default from /etc/umurmur.conf! If you want I can change this in a new pull request (and then in our package on Arch as well). |
|
As an add-on: I did this pull request because the cmake setup tried to do guess work about existing configuration files and by default the config ended up in /usr/etc/umurmur.conf (which does not adhere to FHS). |
CMakeLists.txt: The changes introduced in umurmur#164 install the configuration to /etc/umurmur/umurmur.conf by default. However, umurmurd is picking up the configuration from /etc/umurmur.conf automatically, which makes that location a more logical default.
CMakeLists.txt:
Include GNUInstallDirs and use CMAKE_INSTALL_SYSCONFDIR to install the
example configuration (defaults to /etc/umurmur/umurmur.conf). The
configuration is installed with 0640 permissions as it may contain
passwords and therefore should not be world readable.
Remove prior checks to the system for umurmur.conf as the merging or
backup of configuration files is historically taken care of by a package
management system on a target system.