Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-7630] update board status in frontend #3962

Merged
merged 2 commits into from
May 28, 2024

Conversation

JohnN193
Copy link
Member

@JohnN193 JohnN193 commented May 15, 2024

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label May 15, 2024
@JohnN193 JohnN193 changed the title update board status in frontend [RSDK-7630] update board status in frontend May 15, 2024
Copy link
Contributor

@ethanlook ethanlook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, have you tested this with a real board?

It's worth noting that this breaking change means RC will not work for old RDK versions from before the API change now.

@JohnN193
Copy link
Member Author

Good point, we were just testing with fake yesterday. Can make sure this gets tested with a board

It's worth noting that this breaking change means RC will not work for old RDK versions from before the API change now.

Should be fine, we mainly noticed it because the new API wasn’t functioning when people were testing

@JohnN193 JohnN193 added the appimage Build AppImage of PR label May 16, 2024
@randhid
Copy link
Member

randhid commented May 16, 2024

Good point, we were just testing with fake yesterday. Can make sure this gets tested with a board

It's worth noting that this breaking change means RC will not work for old RDK versions from before the API change now.

Should be fine, we mainly noticed it because the new API wasn’t functioning when people were testing

We should hold off on this change until micro-rdk is also updated, cc @npmenard

@randhid
Copy link
Member

randhid commented May 17, 2024

Good point, we were just testing with fake yesterday. Can make sure this gets tested with a board

It's worth noting that this breaking change means RC will not work for old RDK versions from before the API change now.

Should be fine, we mainly noticed it because the new API wasn’t functioning when people were testing

We should hold off on this change until micro-rdk is also updated, cc @npmenard

The pr we're waiting for: viamrobotics/micro-rdk#207

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 17, 2024
@JohnN193
Copy link
Member Author

Do we still want to get this into the release

@randhid
Copy link
Member

randhid commented May 23, 2024

Do we still want to get this into the release

We need to wait until micro-rdk merges their PR in, I believe, since the board is functional, and it may affect a project in fight. Can you check with @npmenard or @stevebriskin to see if anything has changed there?

@npmenard
Copy link
Member

Do we still want to get this into the release

We need to wait until micro-rdk merges their PR in, I believe, since the board is functional, and it may affect a project in fight. Can you check with @npmenard or @stevebriskin to see if anything has changed there?

@Gautham should confirm but i think micro-rdk is covered

@randhid
Copy link
Member

randhid commented May 23, 2024

Do we still want to get this into the release

We need to wait until micro-rdk merges their PR in, I believe, since the board is functional, and it may affect a project in fight. Can you check with @npmenard or @stevebriskin to see if anything has changed there?

@Gautham should confirm but i think micro-rdk is covered

Okay we'll wait for @gvaradarajan to confirm. The pr on micro-rdk isn't merged in yet viamrobotics/micro-rdk#207

@JohnN193
Copy link
Member Author

got confirmation that this was okay to merge!

@JohnN193 JohnN193 merged commit b6cf968 into viamrobotics:main May 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appimage Build AppImage of PR safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
5 participants