-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-7630] update board status in frontend #3962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, have you tested this with a real board?
It's worth noting that this breaking change means RC will not work for old RDK versions from before the API change now.
Good point, we were just testing with fake yesterday. Can make sure this gets tested with a board
Should be fine, we mainly noticed it because the new API wasn’t functioning when people were testing |
We should hold off on this change until micro-rdk is also updated, cc @npmenard |
The pr we're waiting for: viamrobotics/micro-rdk#207 |
Do we still want to get this into the release |
We need to wait until micro-rdk merges their PR in, I believe, since the board is functional, and it may affect a project in fight. Can you check with @npmenard or @stevebriskin to see if anything has changed there? |
@Gautham should confirm but i think micro-rdk is covered |
Okay we'll wait for @gvaradarajan to confirm. The pr on micro-rdk isn't merged in yet viamrobotics/micro-rdk#207 |
got confirmation that this was okay to merge! |
Updates to match this api: viamrobotics/api#490
ticket: https://viam.atlassian.net/browse/RSDK-7630