Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-7371: remove AnalogStatus and DigitalInterruptStatus from common API #490

Merged
merged 3 commits into from
Apr 29, 2024
Merged

RSDK-7371: remove AnalogStatus and DigitalInterruptStatus from common API #490

merged 3 commits into from
Apr 29, 2024

Conversation

martha-johnston
Copy link
Contributor

No description provided.

@martha-johnston martha-johnston requested review from a team and susmitaSanyal and removed request for a team April 26, 2024 15:51
@martha-johnston martha-johnston requested review from a team and penguinland and removed request for a team April 29, 2024 17:00
@martha-johnston
Copy link
Contributor Author

@penguinland added you since Susmita is out sick today. Not a huge rush to get merged, but I do have two other open PRs blocked by this one, so if you have time to look at it today that'd be great but if not no worries at all.

penguinland
penguinland approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@penguinland penguinland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Rand is right that this likely requires updating all code that uses the Status message, meaning updating the RDK and all the SDKs. but you probably knew that already.

@martha-johnston
Copy link
Contributor Author

LGTM!

Rand is right that this likely requires updating all code that uses the Status message, meaning updating the RDK and all the SDKs. but you probably knew that already.

yep those are the PRs I have waiting on this one, thanks!

@martha-johnston martha-johnston added the ready-for-protos add this when you want protos to compile on every commit label Apr 29, 2024
@martha-johnston martha-johnston removed the request for review from Simberific April 29, 2024 18:32
@martha-johnston martha-johnston added the safe to test committer is a member of this org label Apr 29, 2024
@martha-johnston martha-johnston added safe to test committer is a member of this org and removed safe to test committer is a member of this org labels Apr 29, 2024
@martha-johnston martha-johnston merged commit d433802 into viamrobotics:main Apr 29, 2024
6 checks passed
@zaporter-work zaporter-work mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randhid randhid randhid left review comments

@penguinland penguinland penguinland approved these changes

@susmitaSanyal susmitaSanyal Awaiting requested review from susmitaSanyal susmitaSanyal was automatically assigned from viamrobotics/bucket

Assignees
No one assigned
Labels
ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martha-johnston @penguinland @randhid