Fix post revision action link by getting the adjacent revision #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $revision_id = absint( wp_stream_get_meta( $record, 'revision_id', true ) ); | ||
| $revision_id = self::get_adjacent_post_revision( $revision_id, false ); | ||
|
|
||
| if ( wp_is_post_revision( $revision_id ) ) { |
There was a problem hiding this comment.
@fjarrett get_adjacent_post_revision already does that check internally. Also i think we should first check if $revision_id is empty or not, so as not to make the extra function call if it was empty.
fjarrett
added a commit
that referenced
this pull request
Nov 19, 2014
Fix post revision action link by getting the adjacent revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking another stab at #585, this time using a workaround that finds the adjacent revision ID.
Unfortunately, the
revision_idbeing saved as record meta is still incorrect. But this PR does fix the action link problem to arrive to the correct revision for that record.@shadyvb please review.