Print percentiles in benchmark #2699
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* separate argument tests from behaviour test * use eskip to define filter configuration * use TestFifo prefix for all test names Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
* feature: filter fifoWithBody that works similar to fifo(), but release deferred until body streaming to client was finished * fix: fifo() and fifoWithBody() with canceled requests Both filters did not check for canceled context from request before semaphore.Acquire, see golang/go#63615 Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
This is needed to improve the performance impact of this component. Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
force-pushed
the
printPercentilesInBenchmark_2
branch
from
85139c5
to
b02f03f
Compare
szuecs
reviewed
Oct 26, 2023
| @@ -72,6 +72,7 @@ require ( | |||
| github.com/OneOfOne/xxhash v1.2.8 // indirect | |||
| github.com/agnivade/levenshtein v1.1.1 // indirect | |||
| github.com/armon/go-metrics v0.0.0-20180917152333-f0300d1749da // indirect | |||
| github.com/benburkert/pbench v0.0.0-20160623210926-4ec5821845ef // indirect | |||
There was a problem hiding this comment.
dependency from 2016, do we need this or can we copy a function into our code base?
szuecs
reviewed
Oct 26, 2023
| @@ -93,6 +94,7 @@ require ( | |||
| github.com/envoyproxy/protoc-gen-validate v1.0.2 // indirect | |||
| github.com/felixge/httpsnoop v1.0.3 // indirect | |||
| github.com/fsnotify/fsnotify v1.6.0 // indirect | |||
| github.com/gavv/monotime v0.0.0-20190418164738-30dba4353424 // indirect | |||
There was a problem hiding this comment.
dependency from 2019 maybe we can copy a func to our own repository
AlexanderYastrebov
force-pushed
the
cw2023freeze
branch
from
803d0c9
to
ede5467
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to improve the performance impact of this component.