Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stuck lifo() -> done() notifications #1086

Merged
merged 1 commit into from
Jun 7, 2019
Merged

fix stuck lifo() -> done() notifications #1086

merged 1 commit into from
Jun 7, 2019

Conversation

aryszka
Copy link
Contributor

@aryszka aryszka commented Jun 7, 2019

make sure each lifo done() is called and handle done() for multiple lifo() filters

Signed-off-by: Arpad Ryszka arpad.ryszka@gmail.com

@aryszka
make sure each lifo done() is called and handle done() for multiple l…
0bb3689 
…ifo() filters

Signed-off-by: Arpad Ryszka <arpad.ryszka@gmail.com>
@aryszka aryszka requested a review from szuecs June 7, 2019 14:49
@aryszka
Copy link
Contributor Author

aryszka commented Jun 7, 2019

👍

1 similar comment
@szuecs
Copy link
Member

szuecs commented Jun 7, 2019

👍

@szuecs
Copy link
Member

szuecs commented Jun 7, 2019 •
edited
Loading

Tested in Kubernetes cluster with lifo and ratelimit filter, which triggered this bug.

@szuecs szuecs merged commit 084a4b9 into master Jun 7, 2019
@szuecs szuecs deleted the fix/release-lifo-when-ratelimited branch June 7, 2019 15:05
AlexanderYastrebov added a commit that referenced this pull request Oct 16, 2023
@AlexanderYastrebov
filters/scheduler: handle errors
45b7064 
Make lifo, lifoGroup and fifo filters backed error aware and remove
cleanup from the proxy.

Follow up on #1054, #1086 and #2239
Updates #1238

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov mentioned this pull request Oct 16, 2023
Merged
AlexanderYastrebov added a commit that referenced this pull request Oct 16, 2023
@AlexanderYastrebov
filters/scheduler: handle errors
20a7f24 
Make lifo, lifoGroup and fifo filters backed error aware and remove
cleanup from the proxy.

Follow up on #1054, #1086 and #2239
Updates #1238

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
szuecs pushed a commit that referenced this pull request Oct 16, 2023
@AlexanderYastrebov
filters/scheduler: handle errors (#2680)
fe6b8f2 
Make lifo, lifoGroup and fifo filters backed error aware and remove
cleanup from the proxy.

Follow up on #1054, #1086 and #2239
Updates #1238

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
szuecs pushed a commit that referenced this pull request Oct 17, 2023
@AlexanderYastrebov @szuecs
filters/scheduler: handle errors (#2680)
1f45d7c 
Make lifo, lifoGroup and fifo filters backed error aware and remove
cleanup from the proxy.

Follow up on #1054, #1086 and #2239
Updates #1238

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
szuecs pushed a commit that referenced this pull request Nov 7, 2023
@AlexanderYastrebov @szuecs
filters/scheduler: handle errors (#2680)
2b82f25 
Make lifo, lifoGroup and fifo filters backed error aware and remove
cleanup from the proxy.

Follow up on #1054, #1086 and #2239
Updates #1238

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
RomanZavodskikh pushed a commit that referenced this pull request Nov 27, 2023
@AlexanderYastrebov
filters/scheduler: handle errors (#2680)
2e928e1 
Make lifo, lifoGroup and fifo filters backed error aware and remove
cleanup from the proxy.

Follow up on #1054, #1086 and #2239
Updates #1238

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit that referenced this pull request Nov 27, 2023
@AlexanderYastrebov
filters/scheduler: handle errors (#2680)
769e71e 
Make lifo, lifoGroup and fifo filters backed error aware and remove
cleanup from the proxy.

Follow up on #1054, #1086 and #2239
Updates #1238

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit that referenced this pull request Nov 27, 2023
@AlexanderYastrebov
filters/scheduler: handle errors (#2680)
f0c6ab5 
Make lifo, lifoGroup and fifo filters backed error aware and remove
cleanup from the proxy.

Follow up on #1054, #1086 and #2239
Updates #1238

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szuecs szuecs Awaiting requested review from szuecs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryszka @szuecs