Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roll out Profile-V3 #10176

Merged
merged 14 commits into from
May 2, 2024
Merged

roll out Profile-V3 #10176

merged 14 commits into from
May 2, 2024

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Apr 30, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

@daiagi daiagi requested a review from a team as a code owner April 30, 2024 17:13
@daiagi daiagi requested review from preschian and Jarsen136 and removed request for a team April 30, 2024 17:13
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d37233a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6633a32a06f14e0008607f85
😎 Deploy Preview https://deploy-preview-10176--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury
Copy link
Member

prury commented Apr 30, 2024

i'll handle the failing tests

@prury
Copy link
Member

prury commented May 1, 2024

maybe remove the buynow=false at the end:
image

@prury
Copy link
Member

prury commented May 1, 2024

other than the above, works for me, i have added some small visual bugs on visual PR

@daiagi
Copy link
Contributor Author

daiagi commented May 1, 2024

other than the above, works for me, i have added some small visual bugs on visual PR

Fixed.
Thank you :)

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 1, 2024
components/profile/ProfileActivitySummery.vue Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented May 2, 2024

Code Climate has analyzed commit d37233a and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@daiagi
Copy link
Contributor Author

daiagi commented May 2, 2024

@prury

merge conflicts are already resolved

@prury prury added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit aaf55ce May 2, 2024
18 of 19 checks passed
@prury prury deleted the rollout-ProfileV3 branch May 2, 2024 14:58
@prury prury mentioned this pull request May 7, 2024
This was referenced May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants