feat(kumactl) add install control-plane --version flag for all components #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2904 +/- ##
==========================================
+ Coverage 52.14% 52.21% +0.07%
==========================================
Files 897 897
Lines 52069 52083 +14
==========================================
+ Hits 27150 27195 +45
+ Misses 22748 22715 -33
- Partials 2171 2173 +2
Continue to review full report at Codecov.
|
bartsmykla
approved these changes
Oct 7, 2021
Comment on lines
24
to
26
| } | ||
| func (cv *componentVersion) Set(v string) error { |
There was a problem hiding this comment.
Suggested change
| } | |
| func (cv *componentVersion) Set(v string) error { | |
| } | |
| func (cv *componentVersion) Set(v string) error { |
Comment on lines
32
to
35
| } | ||
| func (cv *componentVersion) Type() string { |
There was a problem hiding this comment.
Suggested change
| } | |
| func (cv *componentVersion) Type() string { | |
| } | |
| func (cv *componentVersion) Type() string { |
…ents Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/cp_version
branch
from
bcaa884
to
7bc091c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make it easier to set the various version flags.