Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elbow joint limits #268

Conversation

beatrizleon
Copy link

We want to propose this PR that will fix the joints limits of the elbow joint according with the results discussed in #265 for the ur10 and ur5

@fmessmer fmessmer mentioned this pull request Aug 2, 2017
@v4hn
Copy link

v4hn commented Sep 4, 2017

@ipa-fxm @gavanderhoorn This issue has been raised and analyzed a year ago.
Please merge&release at least #302 to get this fixed in kinetic.
There is still no official driver available for kinetic (the rewritten driver is still pending), so I believe it is well-justified to merge this into indigo too.

Today I talked to one more PhD student who fell into this trap last year and the lab decided not to use MoveIt! after trying for some time. This is the second time I hear about something like that.
This is awful and bad advertisement for Motion Planning in ROS.

@gavanderhoorn gavanderhoorn changed the base branch from indigo-devel to kinetic-devel September 12, 2017 22:09
@gavanderhoorn
Copy link
Member

Not a change that CI has any tests for, so I feel it's justified to merge without waiting for Travis to complete.

@gavanderhoorn gavanderhoorn merged commit 8a8591e into ros-industrial:kinetic-devel Sep 12, 2017
@gavanderhoorn
Copy link
Member

Thank you for taking the time to fix this @beatrizleon 💯

@gavanderhoorn
Copy link
Member

And we should have merged this sooner 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants