Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release into Kinetic #240

Closed
jonbinney opened this issue May 5, 2016 · 19 comments
Closed

Release into Kinetic #240

jonbinney opened this issue May 5, 2016 · 19 comments
Milestone

Comments

@jonbinney
Copy link
Contributor

Are there any other packages currently blocking release?

@pgorczak
Copy link

pgorczak commented Jul 7, 2016

Looks like MoveIt is blocking ur_kinematics, ur3_moveit_config, ur5_moveit_config and ur10_moveit_config

Also, ros-kinetic-gazebo-ros-control can't be found by my package manager despite having been released which breaks ur_gazebo.

@gavanderhoorn
Copy link
Member

A kinetic release of MoveIt is close, but still not out. So this remains blocked by that at least unfortunately (ignoring the Gazebo issues @pgorczak mentioned).

@gavanderhoorn gavanderhoorn modified the milestone: kinetic Dec 30, 2016
@gavanderhoorn
Copy link
Member

As MoveIt is now available on Kinetic, this is no longer blocked (or at least: not by MoveIt).

@SimonBirrell
Copy link

Any idea when we can expect a kinetic release?

@SimonBirrell
Copy link

SimonBirrell commented Jan 1, 2017

For those who are also waiting for the Kinetic release, here's how I got it working:

  1. Install universal_robot repo into your catkin workspace

  2. Add the patch from https://github.com/ros-industrial/universal_robot/pull/254/files
    (This is basically adding a few new lines to ur_kinematics/CMakeLists.txt)

  3. catkin_make

  4. Install ros-control (this solves the ros-control problem mentioned above by @pgorczak).

    sudo apt-get install ros-kinetic-ros-control ros-kinetic-ros-controllers

See http://wiki.ros.org/ros_control for more details.

This seemed to do it for me. A deb install for kinetic would still be nice though.

@shaun-edwards
Copy link
Member

@SimonBirrell, thanks for reporting. With MoveIt released in kinetic, we can begin releasing ROS-Industrial packages. Unfortunately, we don't have a timeline for these releases. We'd welcome an PRs that get's us closer to a release.

@SimonBirrell
Copy link

The existing pull #254 would get you to where I got.

@mikaelarguedas
Copy link

mikaelarguedas commented May 25, 2017

Now that #254 got merged (through #286). Is there any other blocker for a kinetic release?

@davetcoleman
Copy link
Contributor

I built this locally today and I don't see any blockers for a kinetic release, +1

@ipa-rmb
Copy link

ipa-rmb commented Aug 1, 2017

+1 for releasing

@AndyZe
Copy link
Contributor

AndyZe commented Aug 1, 2017

It builds for me (on Kinetic), but I get this error when running roslaunch ur_gazebo ur5.launch.
joint_state_controller was installed by sudo apt install:

[joint_state_controller_spawner-7] process has died [pid 11838, exit code 1, cmd /opt/ros/kinetic/lib/controller_manager/controller_manager spawn joint_state_controller __name:=joint_state_controller_spawner __log:=/home/nrgadmin/.ros/log/7f8c5b46-76f7-11e7-9269-d07e35252268/joint_state_controller_spawner-7.log].
log file: /home/nrgadmin/.ros/log/7f8c5b46-76f7-11e7-9269-d07e35252268/joint_state_controller_spawner-7*.log
[arm_controller_spawner-8] process has died [pid 11852, exit code 1, cmd /opt/ros/kinetic/lib/controller_manager/controller_manager spawn arm_controller __name:=arm_controller_spawner __log:=/home/nrgadmin/.ros/log/7f8c5b46-76f7-11e7-9269-d07e35252268/arm_controller_spawner-8.log].
log file: /home/nrgadmin/.ros/log/7f8c5b46-76f7-11e7-9269-d07e35252268/arm_controller_spawner-8*.log

@fmessmer
Copy link
Contributor

fmessmer commented Aug 2, 2017

I could trigger the release (I guess, I still have the according access rights 😉)
However, I have lost proper overview of the functional state of the repo...as it is been a while I was using UR arms...

Could the more active contributors help me get relevant PRs merged and issues closed? @gavanderhoorn
I will then trigger both tracks - indigo and kinetic

In particular, I see the following relevant:

@jacknlliu
Copy link
Contributor

I think the most import problem is ur_driver, fewer people use this repo with latest real UR robot then fewer people use this repository, and then fewer people contribute for this repository. We should know that ur_modern_driver is out of the ros industrial. If this repository couldn't work with the latest UR robot, why we do these?

@fmessmer
Copy link
Contributor

fmessmer commented Aug 2, 2017

ur_driver has known issues with latest UR HW...(I'm not going to start a discussion about this here)
I just would like to get PRs merged that are already proposed and "approved by discussion" as well as get respective issues closed in order to include them in the next release...

@fmessmer
Copy link
Contributor

fmessmer commented Aug 4, 2017

I'm going to do a release of kinetic-devel in order to get the rosdep keys out...
another release with missing features/merged PRs can easily be done any time soon...

@fmessmer
Copy link
Contributor

fmessmer commented Aug 4, 2017

@jonbinney
Copy link
Contributor Author

Thanks @ipa-fxm !

@davetcoleman
Copy link
Contributor

thanks!

@gavanderhoorn
Copy link
Member

Closing: the pkgs have been released into Kinetic.

tnx @ipa-fxm for taking the time to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests