This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
Add overseer unit tests and fix two bugs #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 8, 2016 18:41
This commit adds some unit tests for the overseer go routine. It partially implements Issue ciao-project#1. Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
Test-cases now gathers up all the output it receives on stderr when running go test. If any of the packages under test fail, test-cases will dump out the collected stderr when it exits. This should make it easy to figure out what went wrong. Right now all you know is that a test failed, which is not enough information. Fixed ciao-project#184 Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
Using one ovsCh for delivering commands to the overseer from both the main and the instance go routine was racy. There was always the chance that an instance routine could write to the ovsCh after it had been closed by the main go routine but before the instance had itself been asked to shutdown by the overseer, which would lead to a panic. Fixes ciao-project#26 Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>
|
@tpepper Could you merge this one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some unit tests for ciao-launcher's overseer go routine. This brings launcher's test coverage up to 30%. The PR also contains a fix for #26. The bug was easily reproducible with the new tests so it needed to be fixed to avoid these new tests failing periodically. Finally, #184 is also fixed. test-cases now prints out the contents of stderr, if one of the packages fails its unit tests. This needed to be fixed to help debug the failing overseer test cases in travis.