Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Need fix all gtest failure things. #741

Closed
xuguangxin opened this issue May 31, 2017 · 5 comments
Closed

Need fix all gtest failure things. #741

xuguangxin opened this issue May 31, 2017 · 5 comments
Assignees
Labels

Comments

@xuguangxin
Copy link
Contributor

Currently, we have 7 issues on SKL, we need to fix them.
CompatibleX11
CreateX11
Format_Change/0
Format_Change/1
ReadAsUnits
ReadAsWhole
guessResolutionOverflow

@uartie
Copy link
Contributor

uartie commented Jun 1, 2017

For the X11 based tests, we should allow those to be disabled/enabled at runtime since not all test environments will have an X server running (e.g. servers). We could do that by prefixing the test names with DISABLED_ (i.e. gtest framework skips DISABLED_ prefixed tests by default, but can be enabled with command line)... or we can check an environment variable set by the user (e.g. YAMI_ENABLE_X11_TESTS=[0|1]).

The ReadAsUnits, ReadAsWhole and guessResolutionOverflow test cases are already fixed by #730... it just needs final review and merged.

@xuguangxin
Copy link
Contributor Author

Thanks for suggestion, we will look it.

after #730 merge.
We have 4 issue left

CompatibleX11
CreateX11
Format_Change/0
Format_Change/1

@uartie
Copy link
Contributor

uartie commented Jun 8, 2017

On SKL and BSW, we also have these failures in decode unittest:

Flush/3
Format_Change/3

...which aren't supported on these platforms and should be skipped at runtime. This means we need a runtime support check feature. Currently, those tests segfault on these platforms.

@xuguangxin
Copy link
Contributor Author

xuguangxin commented Jun 26, 2017

@uartie , it still needs more work to add run-time check in yami. Let use add some check in gtest first. I will send a pull request this week.

@xuguangxin
Copy link
Contributor Author

xuguangxin commented Jul 3, 2017

with #754, all issues fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants