Fix build on current Fedora Rawhide #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module used several functions from string.h without the header file being #included.
Include files under <bits/...> are internal glibc headers. They should be used only in other glibc headers. glibc 2.26 does not have bits/sigset.h anymore. It does not seem to be used for anything anyway, so stop including it. The __signed__ macro is not used either, so remove it too. For some reason these includes and definitions were inside "#if defined(LINT)" blocks. The only other thing in these blocks is "#include <stdlib.h>" in Esm/ib/src/cs/vs_pool_common.c and that seems superfluous there. So drop those blocks altogether.
|
Hi Michal,
Thank you for this pull request. The changes look straightforward. I’ll put this through the internal review cycle now.
Scott Breyer
From: Michal Schmidt [mailto:notifications@github.com]
Sent: Friday, August 18, 2017 11:02 AM
To: 01org/opa-ff <opa-ff@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [01org/opa-ff] Fix build on current Fedora Rawhide (#8)
…________________________________
You can view, comment on, or merge this pull request online at:
#8
Commit Summary
* fe_ssl: add missing #include <string.h>
* Esm/ib/src: fix build with glibc 2.26
File Changes
* M Esm/ib/src/cs/vs_pool_common.c<https://github.com/01org/opa-ff/pull/8/files#diff-0> (4)
* M Esm/ib/src/ibaccess/vs_evt.c<https://github.com/01org/opa-ff/pull/8/files#diff-1> (4)
* M Esm/ib/src/ibaccess/vs_lck.c<https://github.com/01org/opa-ff/pull/8/files#diff-2> (4)
* M Esm/ib/src/ibaccess/vs_thr.c<https://github.com/01org/opa-ff/pull/8/files#diff-3> (4)
* M opa_fe_utils/src/fe_ssl.c<https://github.com/01org/opa-ff/pull/8/files#diff-4> (1)
Patch Links:
* https://github.com/01org/opa-ff/pull/8.patch
* https://github.com/01org/opa-ff/pull/8.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#8>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AN7y0mUqv-cXUoDrqWwC8d6YqxDtZyHJks5sZaeBgaJpZM4O7rE8>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.