Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PyYAML dependency #450

Closed
martinezjavier opened this issue Sep 1, 2017 · 4 comments
Closed

Add a PyYAML dependency #450

martinezjavier opened this issue Sep 1, 2017 · 4 comments
Milestone

Comments

@martinezjavier
Copy link
Contributor

The tpm2_pcrevent.sh test has a Python helper script that uses the PyYAML module, but that dependency isn't present in autotools and so the test fails when trying to execute after everything builds correctly:

$ ./test_tpm2_pcrevent.sh 
Traceback (most recent call last):
  File "./yaml_get.py", line 35, in <module>
    import yaml
ImportError: No module named yaml
old_pcr_value=`./yaml_get.py sha1 9 $yaml_out_file` on line 74 failed: 1
$ sudo dnf install PyYAML

$ ./test_tpm2_pcrevent.sh 
tpm2_pcrevent succeed
@williamcroberts
Copy link
Member

There's no bash dependency nor python check either for that matter.

@martinezjavier
Copy link
Contributor Author

@williamcroberts I think checking for python as well (and having it as a BuildRequires dependency in the RPM package) makes sense.

@williamcroberts
Copy link
Member

williamcroberts commented Sep 1, 2017

We can just warn that running the system tests will fail as well, similar to the md2man check

@martinezjavier
Copy link
Contributor Author

@williamcroberts agreed.

@williamcroberts williamcroberts added this to the next milestone Sep 19, 2017
williamcroberts pushed a commit to williamcroberts/tpm2-tools that referenced this issue Oct 23, 2017
Warn that without python and pyyaml, that some system
test scripts will fail.

Fixes: tpm2-software#450

Signed-off-by: William Roberts <william.c.roberts@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants