Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IllegalArgumentException on Android when dirName has path separator #505

Closed
05nelsonm opened this issue Aug 13, 2024 · 0 comments · Fixed by #506
Closed

IllegalArgumentException on Android when dirName has path separator #505

05nelsonm opened this issue Aug 13, 2024 · 0 comments · Fixed by #506
Labels
android Platform type Android bug Something isn't working
Milestone
2.0.0-alpha01

Comments

@05nelsonm
Copy link
Owner

Under the hood, TorServiceConfig.newEnvironment it's using Context.getDir. It throws the exception if a separator character is present. Need to perform a check and pre-create the directory before passing it to the TorRuntime.Environment.Builder.

Part of #423
@05nelsonm 05nelsonm added the bug Something isn't working label Aug 13, 2024
@05nelsonm 05nelsonm added this to the 2.0.0-alpha01 milestone Aug 13, 2024
@05nelsonm 05nelsonm mentioned this issue Aug 13, 2024
Merged
@05nelsonm 05nelsonm linked a pull request Aug 13, 2024 that will close this issue
Fix error when dirName contains a fs separator #506
Merged
@05nelsonm 05nelsonm added the android Platform type Android label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android Platform type Android bug Something isn't working
Projects
None yet
Milestone
2.0.0-alpha01
Development

Successfully merging a pull request may close this issue.

Fix error when dirName contains a fs separator 05nelsonm/kmp-tor
1 participant
@05nelsonm