Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pagination to problematic endpoints #2125

Merged
merged 11 commits into from
Feb 23, 2023
Merged

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Feb 16, 2023

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@dabasov dabasov self-assigned this Feb 16, 2023
@peterlimg
Copy link
Member

Let's fix the system tests, we might need to update gosdk and clients to adjust the API changes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Merging #2125 (8c84e67) into staging (dc9e1df) will increase coverage by 0.03%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging    #2125      +/-   ##
===========================================
+ Coverage    27.03%   27.06%   +0.03%     
===========================================
  Files          374      374              
  Lines        61900    61851      -49     
===========================================
+ Hits         16733    16739       +6     
+ Misses       43197    43138      -59     
- Partials      1970     1974       +4     
Flag Coverage Δ
Unit-Tests 27.06% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/go/0chain.net/smartcontract/dbs/event/blobber.go 1.65% <ø> (+0.06%) ⬆️
...hain.net/smartcontract/dbs/event/challenge_pool.go 0.00% <0.00%> (ø)
...chain.net/smartcontract/dbs/event/delegate_pool.go 30.88% <0.00%> (-1.94%) ⬇️
...ode/go/0chain.net/smartcontract/minersc/handler.go 5.90% <0.00%> (-0.06%) ⬇️
...et/smartcontract/storagesc/benchmark_rest_tests.go 0.00% <ø> (ø)
...e/go/0chain.net/smartcontract/storagesc/handler.go 0.25% <0.00%> (+<0.01%) ⬆️
...ain.net/smartcontract/storagesc/config_settigns.go 54.76% <0.00%> (ø)
...de/go/0chain.net/smartcontract/vestingsc/config.go 58.42% <0.00%> (+3.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dabasov
Copy link
Member Author

dabasov commented Feb 20, 2023

Let's fix the system tests, we might need to update gosdk and clients to adjust the API changes.

@peterlimg updated related repos, please check

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix/optimize-handlers
zwalletcli staging
0chain fix/optimize-handlers
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped true
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain fix/optimize-handlers
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@dabasov dabasov merged commit 1341b47 into staging Feb 23, 2023
@dabasov dabasov deleted the fix/optimize-handlers branch February 23, 2023 16:59
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix-rounding-off-for-balance
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix-rounding-off-for-balance
zwalletcli fix-rounding-off-for-balance
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli remove-total-stored-data-endpoint
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli remove-total-stored-data-endpoint
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants