Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/optimize handlers #359

Merged
merged 15 commits into from
Feb 23, 2023
Merged

Fix/optimize handlers #359

merged 15 commits into from
Feb 23, 2023

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Feb 20, 2023

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix/optimize-handlers
zwalletcli staging
0chain fix/optimize-handlers
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

cmd/stakepool.go Outdated Show resolved Hide resolved
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped true
system-tests master
gosdk staging
zboxcli fix/optimize-handlers
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@dabasov dabasov merged commit c0f5b5c into staging Feb 23, 2023
peterlimg added a commit that referenced this pull request Mar 3, 2023
# By Laxmi Prasad Oli (13) and others
# Via GitHub (25) and others
* staging: (28 commits)
  Upgrade gosdk to specific commit
  Upgrade gosdk to specific commit
  update gosdk
  Upgrade gosdk to specific commit
  added url update in blobberUpdateCmd
  Upgrade gosdk to specific commit
  Upgrade gosdk to specific commit
  Upgrade gosdk to specific commit
  feature: updated system tests workflow
  fix after rebase
  update gosdk to latest commit
  update gosdk commit
  fix rounding off issues with balance objects
  update gosdk to desired version
  remove total-stored-data cli
  removed allocation flag
  Fix/optimize handlers (#359)
  applied requested changesw
  Upgrade gosdk to specific commit
  Upgrade gosdk to specific commit
  ...

# Conflicts:
#	go.mod
#	go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants