-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allocation ownership transfer is not synced from 0chain #728
Comments
@peterlimg all allocation changes should be synced from blockchain. eg size, write_price, read_price...etc |
@peterlimg @cnlangzi |
@peterlimg @cnlangzi can you please give a brief overview on what should done as a part of this ticket? |
@boddumanohar first, we need to confirm if this bug still exist. So after transferring an allocation's ownership, check if the new owner has the CURD rights? and if how about the old owner. Second, if the bug still exists, then we will need to check what we can do to fix the issue, most likely as @cnlangzi said above, it is because the ownership data hasn't been sync from 0chain, so perhaps, what we can do are:
Another way is to do whole allocations synching periodically, but that may use a lot of resources and cause performance issue as each blobber could have a lot of allocations need to update. |
@peterlimg just checking if this is still a valid issue, we still see flaky behaviour/periodic test failures |
@stewartie4 yes, I've validated and the issue still exists. At the moment, @lpoli is working on it. As is somewhat related to his Writemarker modification PR. The problem is with respect to write maker signature verification. And the associated discussion can be followed here: https://0chain.slack.com/archives/C01U94VF56Y/p1668931208557289 |
@peterlimg this function https://github.com/0chain/blobber/blob/staging/code/go/0chain.net/blobbercore/handler/storage_handler.go#L41 , updates the allocation right , if yes can we just call this function when zbox cli send the update request with txnhash of update owner transaction . |
postponed |
Related issue 0chain/gosdk#765
The text was updated successfully, but these errors were encountered: