Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DownloadFromAuthTicket does not set owner correctly when 3rd party pays #246

Closed
Sriep opened this issue Sep 11, 2021 · 2 comments · Fixed by #446
Closed

DownloadFromAuthTicket does not set owner correctly when 3rd party pays #246

Sriep opened this issue Sep 11, 2021 · 2 comments · Fixed by #446
Assignees
@lpoli
Labels
bug Something isn't working mainnet

Comments

@Sriep
Copy link
Contributor

Sriep commented Sep 11, 2021 •
edited
Loading

downloadBlobberBlock always sets the owner to be the client. This is wrong when a 3rd party pays and the owner is someone else.

The end result seems to be that 0chain read_redeem can fail as it gets confused verifying the signature, assuming the owner has signed it.
@Sriep Sriep added the bug Something isn't working label Sep 11, 2021
This was referenced Sep 11, 2021
Closed
Closed
@Sriep
Copy link
Contributor Author

Sriep commented Sep 12, 2021 •
edited
Loading

Actually, on investigation, while this is clearly confusing, the cause of the problem was caused by 4f105be#diff-dbc2b4d74b0c2ba20c9c503f9afab19b99134642777fe5c087964942dc7b074a where two feids were added to authTicket and its hash and not mirrored in 0chain. this is fixed in 0chain/0chain#521.

@moldis moldis self-assigned this Oct 27, 2021
@moldis moldis added the mainnet label Oct 27, 2021
@lpoli lpoli assigned lpoli and unassigned moldis Apr 14, 2022
@lpoli
Copy link
Contributor

lpoli commented Apr 14, 2022

I've included this in coming PR in refactored download.

@lpoli lpoli linked a pull request Apr 29, 2022 that will close this issue
Set allocation owner id to readmarker's owner id field #446
Merged
@lpoli lpoli closed this as completed in #446 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lpoli lpoli

Labels
bug Something isn't working mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set allocation owner id to readmarker's owner id field 0chain/gosdk
3 participants
@moldis @Sriep @lpoli