-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use minimist instead of yargs to get rid of dependencies #23
Conversation
Using yargs causes 'critical dependency' warning in Electron, adapt it to minimist to get rid of the warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for your work @CW-B-W
Cool pull request, i want you add unit test before i merge it.
Thank you again for your work, everything's cool.
Thanks for you suggestions, I found bugs in parsing the |
Hello @9bany, I have fixed the bugs & add The output of Please review it again, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just release on latest version, thanks @CW-B-W |
Hello @9bany ,
Thanks for your work, I am planning to use
curl-to-json
to add curl support for Motrix, but the dependency ofyargs
causes the following warnings inElectron
.Therefore I adapted it to
minimist
to get rid of the warnings and further reduces the large number of dependencies.I have tested it with my Motrix branch and it works fine, but I don't know whether it affects any feature of your project.
Hope it helps!