Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override Ruby class Float and Integer is a bad pattern #14

Closed
fwininger opened this issue Apr 30, 2020 · 1 comment · Fixed by #17
Closed

Override Ruby class Float and Integer is a bad pattern #14

fwininger opened this issue Apr 30, 2020 · 1 comment · Fixed by #17
Labels
enhancement
Milestone
1.2.1

Comments

@fwininger
Copy link
Contributor

Subject of the issue

Override Ruby class Float and Integer is a bad pattern for a integration in a big project.

Expected behaviour

Use a helper for roundup and round_up methods
@fwininger
Copy link
Contributor Author

I will do a PR for this

This was referenced Apr 30, 2020
Merged
Closed
@0llirocks 0llirocks linked a pull request May 8, 2020 that will close this issue
Simplify round_up and roundup methods #17
Merged
4 tasks
@0llirocks 0llirocks added this to the 1.2.1 milestone May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.2.1
2 participants
@0llirocks @fwininger