Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter 'startVerifyUpstream = false' checks upstream on start #749

Closed
0xERR0R opened this issue Nov 14, 2022 · 3 comments · Fixed by #775
Closed

parameter 'startVerifyUpstream = false' checks upstream on start #749

0xERR0R opened this issue Nov 14, 2022 · 3 comments · Fixed by #775
Assignees
Labels
🐞 bug Something isn't working

Comments

@0xERR0R
Copy link
Owner

0xERR0R commented Nov 14, 2022

When following configuration is used:

upstream:
  default:
    - some.wrong.host
startVerifyUpstream: false

Then blocky fails to start with following message: upstream group default: lookup some.wrong.host on 127.0.0.11:53: no such host

I would expect, the configuration "startVerifyUpstream: false" will disable all startup checks. This is useful if server gets restarted and DNS resolution is not ready if blocky is started.

@0xERR0R 0xERR0R added the 🐞 bug Something isn't working label Nov 14, 2022
@kwitsch
Copy link
Collaborator

kwitsch commented Nov 25, 2022

Do I get it correct that you like to change the default behavior and setting it to true will switch it back to the current default?

@0xERR0R
Copy link
Owner Author

0xERR0R commented Nov 26, 2022

My expectation is:

if startVerifyUpstream = false, which is default, blocky should start even if network is down. No upstream server should be verified. List download will fail. But blocky starts and can answer DNS queries (e.g. custom mapping). All queries to upstream servers will of course fail. If network connection is established again, blocky will operate without issues. Lists will be downloaded on next refresh attempt.

if startVerifyUpstream = true, blocky start should fail.

Current behaviour is, that blocky start fails even if startVerifyUpstream = false

@ThinkChaos
Copy link
Collaborator

Assigned to myself and will submit a MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants