This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Add decoders for broker and stop-limit data #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
force-pushed
the
broker-and-stop-limit-data-decoders
branch
from
78754dc
to
8371bc8
Compare
dorothy-zbornak
approved these changes
Feb 14, 2020
Comment on lines
6
to
7
| proto: BigNumber; | ||
| quality: BigNumber; |
There was a problem hiding this comment.
would the abi encoder accept these if they were just numbers?
There was a problem hiding this comment.
ah yeah, changed to BigNumber | number
Comment on lines
717
to
718
| const MAX_UINT8 = new BigNumber(2).exponentiatedBy(8).minus(1); | ||
| const MAX_UINT16 = new BigNumber(2).exponentiatedBy(16).minus(1); |
There was a problem hiding this comment.
Nit: Seems clearer to just do like new BigNumber(2**8-1)
| @@ -15,12 +27,13 @@ import { LocalBalanceStore } from '../framework/balances/local_balance_store'; | |||
| import { DeploymentManager } from '../framework/deployment_manager'; | |||
| import { ChainlinkStopLimitContract, TestChainlinkAggregatorContract } from '../wrappers'; | |||
|
|
|||
| blockchainTests.resets('Chainlink stop-limit order tests', env => { | |||
| blockchainTests.resets.only('Chainlink stop-limit order tests', env => { | |||
There was a problem hiding this comment.
Suggested change
| blockchainTests.resets.only('Chainlink stop-limit order tests', env => { | |
| blockchainTests.resets('Chainlink stop-limit order tests', env => { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds decoding equivalents to the encoders found in
chainlink_utilsandgods_unchained_utilsTesting instructions
Types of changes
Checklist:
[WIP]if necessary.