Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ switch to just-the-class #249

Merged
merged 18 commits into from
Jan 6, 2021
Merged

✨ switch to just-the-class #249

merged 18 commits into from
Jan 6, 2021

Conversation

nikhiljha
Copy link
Member

This might never get merged, just trying things here.

closes #248

@ja5087
Copy link
Contributor

ja5087 commented Oct 12, 2020

It might be nice to see what this looks like if you have some screenshots

@BernardZhao
Copy link
Member

As long as this preserves the formatting we have for the labs, I'm all for it

@nikhiljha
Copy link
Member Author

@ja5087 see the links at #248 for actual classes that use it - this is what it looks like right now

image

@BernardZhao yeah labs look the same (I copy pasted the existing lab template) 👍

@64bitpandas
Copy link
Member

I've been playing around with this for a couple hours, definitely simple enough to implement before next semester and looks much nicer. I can go ahead and finish this.

I got a sidebar table of contents for the lab docs up:
image

@64bitpandas 64bitpandas marked this pull request as ready for review January 1, 2021 07:41
@64bitpandas
Copy link
Member

At this point, I think I've added everything the previous site had and it should be ready for preliminary review 🔥

Here are some screenshots, but if you have the time I'd appreciate any feedback from actually serving/viewing the site locally as well.

Homepage:
image

Homepage (continued):
image

Lab:
image

There's also a dark mode 😎
image

Staff page:
image

Archives:
image

@BernardZhao
Copy link
Member

Wow this already looks incredible, are you thinking about sticking with the purple?

Copy link
Member

@BernardZhao BernardZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshots look excellent, only thing that I can nitpick is that the lecture and lab chips seems to have differing colors for the beginner and advanced tracks.

@64bitpandas
Copy link
Member

thx for the review ❤️

Wow this already looks incredible, are you thinking about sticking with the purple?

I like purple lol but if you think it should be changed I'm all for making it blue or something

The screenshots look excellent, only thing that I can nitpick is that the lecture and lab chips seems to have differing colors for the beginner and advanced tracks.

I did this intentionally to differentiate between the two tracks, I can fix this if it's too confusing.

Copy link
Contributor

@encadyma encadyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch Jekyll Theme to "Just The Class"
5 participants