-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ switch to just-the-class #249
Conversation
It might be nice to see what this looks like if you have some screenshots |
As long as this preserves the formatting we have for the labs, I'm all for it |
@ja5087 see the links at #248 for actual classes that use it - this is what it looks like right now @BernardZhao yeah labs look the same (I copy pasted the existing lab template) 👍 |
The sidebar is just way too wide on anything >1080p
At this point, I think I've added everything the previous site had and it should be ready for preliminary review 🔥 Here are some screenshots, but if you have the time I'd appreciate any feedback from actually serving/viewing the site locally as well. |
Wow this already looks incredible, are you thinking about sticking with the purple? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screenshots look excellent, only thing that I can nitpick is that the lecture and lab chips seems to have differing colors for the beginner and advanced tracks.
thx for the review ❤️
I like purple lol but if you think it should be changed I'm all for making it blue or something
I did this intentionally to differentiate between the two tracks, I can fix this if it's too confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
This might never get merged, just trying things here.
closes #248