Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExportedType resolves incorrectly #13

Closed
yck1509 opened this issue Sep 27, 2014 · 1 comment · Fixed by #14
Closed

ExportedType resolves incorrectly #13

yck1509 opened this issue Sep 27, 2014 · 1 comment · Fixed by #14

Comments

@yck1509
Copy link
Contributor

yck1509 commented Sep 27, 2014

In dnlib.DotNet.Resolver.FindExportedType, IsForwarder flag is checked before determining whether it's the correct exported type. However, the CLI standard does not contains this flag, and the SSCLI source code seems to have no special processing about the flag (except reject it if it is generic type). Moreover, according to the source code of Roslyn, it seems that nested types will have this flag unset even if it is exported. Therefore, I think this check of IsForwarder should be omitted.
@0xd4d
Copy link
Collaborator

0xd4d commented Sep 27, 2014

You're right. The ECMA spec doesn't mention anything about nested type forwarders having that flag set. :)

You want to write the patch? Otherwise I'll do it later.

@yck1509 yck1509 mentioned this issue Sep 27, 2014
Merged
@0xd4d 0xd4d closed this as completed in #14 Sep 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the check of IsForwarder flag yck1509/dnlib
1 participant
@yck1509