-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve build process #1205
Improve build process #1205
Conversation
There's one thing I'd like your feedback on. I shortened the names of the output JS files in this PR. Is everyone okay with removing the "-min" from the minified files? Our files are all minified, except for
Tone.js also does this. For example, this is minified: https://unpkg.com/tone/build/Tone.js |
The filename renaming is fine with me -- it does make more sense since Also, glad to be rid of jQuery. |
Change looks good. One conflict after all those merges to fix :-) LMK when this is good to go. |
to run a streamlined vexflow-tests.js. The full flow.html will include things like async loading of web fonts, etc. Generate .d.ts files. Gruntfile improvements to allow for dynamic font loading. Delete jQuery file. Update glyphs.html to not require jQuery.
0f5707a
to
7427ff0
Compare
Remove glyphs.html because the updated one was introduced in a different PR.
Fixed conflicts. Good to go. Once this is merged, I'll rebase my Font PR to see where we're at. :-) The remaining Font related changes cut across much of the VexFlow code base, so I'll try to figure out the best way for you to review (perhaps by writing a "how to review" document, haha). Or maybe I can extract one more PR. I've been working with Rodrigo to iron out any last migration issues with my Fonts branch. We're down to a single (albeit tricky) issue. |
Thanks Ron. Merging. |
Generate .d.ts files (tsconfig.json setting).
Generate a vexflow.module.js file (that ends in
export default Vex;
).Add flow-headless-browser.html to allow the qunit grunt task to run a streamlined vexflow-tests.js. The full flow.html will include things like async loading of web fonts, etc. The command line tests will not preload web fonts.
Gruntfile improvements to allow for dynamic font loading.
Delete jQuery file. Update glyphs.html to not require jQuery.
The output JS files are now as follows:
This was extracted out of the mega Font PR #1163