Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Migrating to ESLint
Currently VexFlow is in the process of migrating to eslint. Using a much stricter config than the previous jshint config provided.
You have two options:
grunt eslint will run eslint on all the
ESLINT_SOURCES expected to pass in the Gruntfile. You could just add a failing file to that array.
Or you can run eslint independently of grunt:
cd <vexflow root> npm install eslint <path>
UPDATE: On master, the first two steps have been run on each file. Only manual edits remain
Run code through
lebab <filepath> -o <filepath>
Lebabis an ES5 to ES6 converter.
- You can install it with
- It seems to work quite well, but be sure to review the result because some transforms are unsafe.
- This will fix some pretty trivial things, but definitely saves time.
- Manual edits
- Despite the automated bits, many errors will remain.
- Sometimes minor refactoring will be required
- When finished add the file name to the
ESLINT_SOURCESarray in the
Config located here: https://github.com/0xfe/vexflow/blob/master/.eslintrc.json