Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases of the authentication.js aren't aligned with the description of the assignment #55

Open
shubhshubh07 opened this issue Jun 21, 2023 · 0 comments

Comments

@shubhshubh07
Copy link

  1. The description of all the routes has id field as well, which is generated every time a new user is created and is unique to each user. But the test cases has no mention of the id field.

  2. The expected response of /login route says

Response: 200 OK with an authentication token in JSON format if successful, or 401 Unauthorized if the credentials are invalid."

But, the tests are not checking if auth code is being returned as response or not.

I would suggest, the tests to be revisited once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant