[BUGFIX] Les résultat Pix+ ne doivent pas apparaître dans les résultats de certification (PF-1098) #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HEYGUL
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
|
I'm deploying this PR to these urls:
Please check it out! |
HEYGUL
force-pushed
the
pf-1098_fix-competences-areas-list-in-certification
branch
from
1fdf499
to
633164c
Compare
PhilippineLoison
added
Func Review OK
HEYGUL
force-pushed
the
pf-1098_fix-competences-areas-list-in-certification
branch
2 times, most recently
from
b8f2c1d
to
b25bdc5
Compare
MelanieMEB
approved these changes
Feb 19, 2020
jonathanperret
changed the title
celineung
reviewed
Feb 19, 2020
api/tests/acceptance/application/certifications/certification-controller_test.js
Outdated
Show resolved
Hide resolved
api/tests/acceptance/application/certifications/certification-controller_test.js
Outdated
Show resolved
Hide resolved
celineung
approved these changes
Feb 19, 2020
HEYGUL
force-pushed
the
pf-1098_fix-competences-areas-list-in-certification
branch
2 times, most recently
from
a718ca2
to
29df28f
Compare
HEYGUL
force-pushed
the
pf-1098_fix-competences-areas-list-in-certification
branch
from
29df28f
to
04fae79
Compare
HEYGUL
force-pushed
the
pf-1098_fix-competences-areas-list-in-certification
branch
from
04fae79
to
15ec0a8
Compare
HEYGUL
deleted the
pf-1098_fix-competences-areas-list-in-certification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Quand des compétences / domaines non-Pix (Pix+) existent dans le référentiel, elles ne sont pas certifiables.
Actuellement, le problème est que ces compétences sont affichées dans les résultats de certification.
🤖 Solution
Filtrer les compétences / domaines affichées dans les résultats de certification qui ne sont pas Pix.
🌈 Remarques
En faisant la modification, les tests de
certification-controlleréchouaient.En essayant de comprendre pourquoi, j'ai constaté que les tests n'utilisaient pas les
buildersrendant la lecture et la compréhension des tests.J'ai donc commencé par un refacto de
certification-controller_test.