Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate libcanard via git subtree and upgrade to libcanard/v3.1.1 #248

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Integrate libcanard via git subtree and upgrade to libcanard/v3.1.1 #248

merged 4 commits into from
Sep 4, 2023

Conversation

aentinger
Copy link
Member

No description provided.

pavel-kirienko and others added 4 commits April 30, 2023 02:32
@pavel-kirienko
Refactor the transfer reassembly state machine to enhance its maintai…
644d3f7 
…nability and robustness (#215)

This is a step towards improving the transfer reassembler.

This changeset also renames `redundant_transport_index` as
`redundant_iface_index` for consistency with the other implementations;
this change is not visible at the API level.
@aentinger
Remove CMakeLists.txt from libcanard folder.
4b6943e
@aentinger
Remove directly inserted libcanard via copy/paste.
acc1a0d
@aentinger
Add 'src/libcanard/' from commit '644d3f711f4b26f29e0e4a25a596a071388…
4b51e5b 
…c7022'

git-subtree-dir: src/libcanard
git-subtree-mainline: acc1a0d
git-subtree-split: 644d3f7
@aentinger aentinger added topic: firmware Code that runs on an embedded system. type: enhancement PR to improve the project. labels Sep 4, 2023
@aentinger aentinger self-assigned this Sep 4, 2023
@aentinger
Copy link
Member Author

Hi @pavel-kirienko ☕ 👋

Can you please review this one? First usage of git subtree by yours truly ... .

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Memory usage change @ 4b51e5b

Board flash % RAM for global variables %
arduino:renesas_portenta:portenta_c33 🔺 +48 - +52 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:renesas_uno:minima 🔺 +40 - +56 +0.02 - +0.02 0 - 0 0.0 - 0.0
rp2040:rp2040:arduino_nano_connect 🔺 +72 - +80 0.0 - 0.0 0 - 0 0.0 - 0.0
rp2040:rp2040:rpipico 🔺 +72 - +80 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/OpenCyphal-Blink
flash		 % examples/OpenCyphal-Blink
RAM for global variables		 % examples/OpenCyphal-Heartbeat-Publisher
flash		 % examples/OpenCyphal-Heartbeat-Publisher
RAM for global variables		 % examples/OpenCyphal-Heartbeat-Subscriber
flash		 % examples/OpenCyphal-Heartbeat-Subscriber
RAM for global variables		 % examples/OpenCyphal-Service-Client
flash		 % examples/OpenCyphal-Service-Client
RAM for global variables		 % examples/OpenCyphal-Service-Server
flash		 % examples/OpenCyphal-Service-Server
RAM for global variables		 %
arduino:renesas_portenta:portenta_c33 52 0.0 0 0.0 52 0.0 0 0.0 48 0.0 0 0.0 52 0.0 0 0.0 52 0.0 0 0.0
arduino:renesas_uno:minima 56 0.02 0 0.0 56 0.02 0 0.0 40 0.02 0 0.0 48 0.02 0 0.0 56 0.02 0 0.0
rp2040:rp2040:arduino_nano_connect 80 0.0 0 0.0 72 0.0 0 0.0 80 0.0 0 0.0 80 0.0 0 0.0 80 0.0 0 0.0
rp2040:rp2040:rpipico 80 0.0 0 0.0 72 0.0 0 0.0 80 0.0 0 0.0 80 0.0 0 0.0 80 0.0 0 0.0
Click for full report CSV 
Board,examples/OpenCyphal-Blink<br>flash,%,examples/OpenCyphal-Blink<br>RAM for global variables,%,examples/OpenCyphal-Heartbeat-Publisher<br>flash,%,examples/OpenCyphal-Heartbeat-Publisher<br>RAM for global variables,%,examples/OpenCyphal-Heartbeat-Subscriber<br>flash,%,examples/OpenCyphal-Heartbeat-Subscriber<br>RAM for global variables,%,examples/OpenCyphal-Service-Client<br>flash,%,examples/OpenCyphal-Service-Client<br>RAM for global variables,%,examples/OpenCyphal-Service-Server<br>flash,%,examples/OpenCyphal-Service-Server<br>RAM for global variables,%
arduino:renesas_portenta:portenta_c33,52,0.0,0,0.0,52,0.0,0,0.0,48,0.0,0,0.0,52,0.0,0,0.0,52,0.0,0,0.0
arduino:renesas_uno:minima,56,0.02,0,0.0,56,0.02,0,0.0,40,0.02,0,0.0,48,0.02,0,0.0,56,0.02,0,0.0
rp2040:rp2040:arduino_nano_connect,80,0.0,0,0.0,72,0.0,0,0.0,80,0.0,0,0.0,80,0.0,0,0.0,80,0.0,0,0.0
rp2040:rp2040:rpipico,80,0.0,0,0.0,72,0.0,0,0.0,80,0.0,0,0.0,80,0.0,0,0.0,80,0.0,0,0.0

pavel-kirienko
pavel-kirienko approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine but why are you not using a submodule here? Version tracking is easier with submodules.

@aentinger
Copy link
Member Author

I would but the Arduino library manager forbids git submodules.

@aentinger aentinger merged commit 03cc836 into main Sep 4, 2023
18 of 20 checks passed
@aentinger aentinger deleted the libcanard-as-subtree branch September 4, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-kirienko pavel-kirienko pavel-kirienko approved these changes

Assignees

@aentinger aentinger

Labels
topic: firmware Code that runs on an embedded system. type: enhancement PR to improve the project.
Projects
Cyphal/Arduino
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aentinger @pavel-kirienko