Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to libcanard v1.0 #48

Merged
merged 12 commits into from
Nov 17, 2020
Merged

Updating to libcanard v1.0 #48

merged 12 commits into from
Nov 17, 2020

Conversation

aentinger
Copy link
Member

@aentinger aentinger self-assigned this Oct 13, 2020
@pavel-kirienko
Copy link
Member

so stable

@aentinger
Copy link
Member Author

Yes 😉 I'll look into it (but tomorrow at the earliest). If you've any insights earlier I'd appreciate to hear them though 😉

@pavel-kirienko
Copy link
Member

My point is that we are feeling stable this week (very). Watch us release Specification v1.0-beta any day now.

The issues appear to be caused by the fact that we moved three bits in the Heartbeat and cut off the two most significant bits of the Subject-ID, thereby making them reserved. This won't affect the wire compatibility much but the code needs updating.

@aentinger
Copy link
Member Author

Ah, the big 1.0. Congratulations on the release, this is certainly a grand achievement 🍾 ! I'll update the link to the spec in the README as soon as you release it (Maybe give me a ping?).

Regarding my failing unit tests: If I copy you correctly I simply need to generate new testdata with the latest version of nunavut?

@pavel-kirienko
Copy link
Member

I simply need to generate new testdata with the latest version of nunavut?

That would appear to be correct, but don't quote me on this as I am not familiar with your codebase.

@aentinger aentinger mentioned this pull request Nov 5, 2020
@107-systems 107-systems deleted a comment from github-actions bot Nov 17, 2020
@aentinger aentinger marked this pull request as ready for review November 17, 2020 07:36
@aentinger aentinger merged commit 5b899ff into master Nov 17, 2020
@aentinger aentinger deleted the uavcan-v1.0 branch November 17, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants