Fixing build issues when using this library with ESP32. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orted. This commit changes the code to conventional namespaces therefore allowing CI to pass for ESP32.
aentinger
added
topic: firmware
aentinger
changed the title
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 17 17
Lines 506 506
=======================================
Hits 432 432
Misses 74 74
Continue to review full report at Codecov.
|
aentinger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP32 Core does not support C++14, ergo no nested namespaces are supported. This commit changes the code to conventional namespaces therefore allowing CI to pass for ESP32.
This fixes #69.