Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for random ordering with seeds #1639

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

asharirfan
Copy link
Collaborator

Description of the Change

This PR adds support for using RAND function in the orderby field for search queries.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#1490

Changelog Entry

  • Add support for RAND function for orderby field in search queries.

@tlovett1
Copy link
Member

Looks like this is already supported. What does this PR do?

@asharirfan
Copy link
Collaborator Author

Looks like this is already supported. What does this PR do?

@tlovett1 Right now, only 'orderby' => 'rand' is supported. This PR adds the support for the RAND function which lets a user pass seed value to the function.

You can read more about it over here: #1490 (comment)

@mustafauysal
Copy link
Contributor

@brandwaffle I have added the test in f70ee87
Can we do cherry-pick after the merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants