Ngram fields for orders autosuggest #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
changed the title
JakePT
requested changes
Feb 21, 2023
|
For now, we are just searching on the fields that are being displayed. |
JakePT
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR introduces the code needed so orders autosuggest start using ngram fields. As autosuggest and the orders autosuggest have some intersection between fields and mapping changes, the common code was moved to the indexable and post indexable classes.
It is done by adding a
term_suggestfield to all orders, filled with all fields we want to be searchable.Closes #3281
How to test the Change
Changelog Entry
Add this to the orders autosuggest PRs list
Credits
Props @felipeelia
Checklist: