-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add custom workspace #56
Feat/add custom workspace #56
Conversation
Edits from original assume that assets & ignore list are in project root Only code to be committed to Plugin repo are placed elsewhere.
7508df1
to
4642d92
Compare
7be2818
to
afade53
Compare
afade53
to
9a70cd9
Compare
Annoyingly this is not exporting my vendor folder (super annoying) I have tried
|
9a70cd9
to
8a78f6d
Compare
This was used to deploy https://wordpress.org/plugins/enable-svg-uploads/#description using https://github.com/Lewiscowles1986/WordPressSVGPlugin/blob/main/.github/workflows/release.yml Currently I'm fine using the fork, but ping if this is of interest, and I'll try to address any concerns. There was a bit of pain in working out I need to git commit generated files from this action for example. This will impact anyone bundling vendor dependencies using composer and then adding to their SVN deploy step as it will not be included in |
echo "➤ Copying files..." | ||
if [[ -e "$GITHUB_WORKSPACE/.distignore" ]]; then | ||
echo "ℹ︎ Using .distignore" | ||
# Copy from current branch to /trunk, excluding dotorg assets | ||
# The --delete flag will delete anything in destination that no longer exists in source | ||
rsync -rc --exclude-from="$GITHUB_WORKSPACE/.distignore" "$GITHUB_WORKSPACE/" trunk/ --delete --delete-excluded | ||
rsync -rc --exclude-from="$GITHUB_WORKSPACE/.distignore" "$WORKSPACE_DIR/" trunk/ --delete --delete-excluded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, we're in the $SNV_DIR
, if $WORKSPACE_DIR
is set to a relative path, this this command will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and my other PR have been working since 2020. Thank you for your input. I am closing this PR.
Requirements
Addresses #16 by re-approaching #30
Description of the Change
#16 is about having the code to push to the plugin repository in a separate folder to the git repo root.
This is a pattern I am familiar with through https://github.com/Lewiscowles1986/WordPressSVGPlugin
WordPress does not use or support Composer, so I ship my plugin with it's own autoloader and vendor folder.
I Like to keep the code separate to the vendor folder.
Also guards (WiP) the image subversion attribute change to cut down chatty logs
Alternate Designs
Benefits
Possible Drawbacks
Technical complexity. A Thing is less easy to think about like this. People may enter paths that do not exist (possible future iteration).
Verification Process
I have not verified this, although I would be happy to think about how to do that. It's currently holding back a PR 😂
Checklist:
I would like help with these two if it is available... (I appeased shellcheck 😉 )
https://github.com/Lewiscowles1986/WordPressSVGPlugin/runs/1294128965 shows this as working.
Applicable Issues
#16
Changelog Entry
WORKSPACE_DIR